cc: Make raster source members const

cc: Make raster source members const

Both PicturePileImpl and DisplayListRasterSource get used on multiple
threads, so should not be mutable.

Unfortunately, many tests try to mutate either the recordings or the
state of PicturePileImpl, so they all need to be changed to touch the
recording source and a bunch of state setters need to be moved from
raster source to recording source.

Committed: https://crrev.com/ffe5781a8645d2fcb9f15a218aca4a3be5fe452c
Cr-Commit-Position: refs/heads/master@{#316364}

[enne (OOO), 2015-02-14 00:13:59]

enne@chromium.org changed reviewers:
+ danakj@chromium.org

[enne (OOO), 2015-02-14 00:14:40]

So much plumbing and rearranging for just a few consts, but hopefully this will
prevent anybody from doing the wrong thing with PicturePileImpl in the future.

[danakj, 2015-02-14 01:34:17]

LGTM

https://codereview.chromium.org/930503002/diff/20001/cc/resources/picture_pil...
File cc/resources/picture_pile_impl.cc (left):

https://codereview.chromium.org/930503002/diff/20001/cc/resources/picture_pil...
cc/resources/picture_pile_impl.cc:43:
clear_canvas_with_debug_color_(kDefaultClearCanvasSetting),
I think you could have left this one alone, there's no setters on the pile. But
this is okay too if you want.

https://codereview.chromium.org/930503002/diff/20001/cc/test/fake_picture_pile.h
File cc/test/fake_picture_pile.h (right):

https://codereview.chromium.org/930503002/diff/20001/cc/test/fake_picture_pil...
cc/test/fake_picture_pile.h:65: void SetClearCanvasWithDebugColor(bool clear) {
oic nvm

[enne (OOO), 2015-02-14 01:37:57]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-02-14 01:38:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930503002/20001

[commit-bot: I haz the power, 2015-02-14 02:37:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-14 02:38:14]

Patchset 2 (id:??) landed as
https://crrev.com/ffe5781a8645d2fcb9f15a218aca4a3be5fe452c
Cr-Commit-Position: refs/heads/master@{#316364}