Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3084)

Unified Diff: chrome/browser/sync/sessions/status_controller.h

Issue 9305001: sync: Remove the remaining conflict sets code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove failing assertion. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/status_controller.h
diff --git a/chrome/browser/sync/sessions/status_controller.h b/chrome/browser/sync/sessions/status_controller.h
index 651e90c6acedd9c6b09f32dc4d8f2c6d9cf4f2f5..a1287fd8c4494b5f95e95e2cc9fe2513dc977334 100644
--- a/chrome/browser/sync/sessions/status_controller.h
+++ b/chrome/browser/sync/sessions/status_controller.h
@@ -147,17 +147,17 @@ class StatusController {
// If a GetUpdates for any data type resulted in downloading an update that
// is in conflict, this method returns true.
- // Note: this includes non-blocking conflicts.
+ // Note: this includes unresolvable conflicts.
bool HasConflictingUpdates() const;
- // Aggregate sum of ConflictingItemSize() over all ConflictProgress objects
- // (one for each ModelSafeGroup currently in-use).
- // Note: this does not include non-blocking conflicts.
- int TotalNumBlockingConflictingItems() const;
+ // Aggregate sum of SimpleConflictingItemSize() over all ConflictProgress
+ // objects (one for each ModelSafeGroup currently in-use).
+ // Note: this does not include unresolvable conflicts.
+ int TotalNumSimpleConflictingItems() const;
- // Aggregate sum of ConflictingItemSize() and NonblockingConflictingItemsSize
- // over all ConflictProgress objects (one for each ModelSafeGroup currently
- // in-use).
+ // Aggregate sum of SimpleConflictingItemSize() and other
+ // ${Type}ConflictingItemSize() methods over all ConflictProgress objects (one
+ // for each ModelSafeGroup currently in-use).
int TotalNumConflictingItems() const;
// Returns the number of updates received from the sync server.
« no previous file with comments | « chrome/browser/sync/sessions/session_state_unittest.cc ('k') | chrome/browser/sync/sessions/status_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698