Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 930493002: Remove an unneeded forward declaration. (Closed)

Created:
5 years, 10 months ago by juanlang (chromium.org)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unneeded forward declaration. BUG=457769 R=pkasting@chromium.org,rockot@chromium.org Committed: https://crrev.com/b59a3395e6e276e715d9972749ec5c4cefb4157a Cr-Commit-Position: refs/heads/master@{#316348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
juanlang (chromium.org)
Peter, as you requested. Ken, owners approval plz?
5 years, 10 months ago (2015-02-13 23:43:49 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-13 23:45:00 UTC) #3
Peter Kasting
Yay!
5 years, 10 months ago (2015-02-13 23:45:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930493002/1
5 years, 10 months ago (2015-02-13 23:47:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25196)
5 years, 10 months ago (2015-02-14 00:43:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930493002/1
5 years, 10 months ago (2015-02-14 00:45:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 01:12:47 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 01:13:40 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b59a3395e6e276e715d9972749ec5c4cefb4157a
Cr-Commit-Position: refs/heads/master@{#316348}

Powered by Google App Engine
This is Rietveld 408576698