Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 930453002: Re-enable some OmniboxViewTests on Windows (Closed)

Created:
5 years, 10 months ago by hichris123
Modified:
5 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable some OmniboxViewTests on Windows Currently, PopupAccelerators and BasicTextOperations are disabled on Windows due to flakiness & timing out. This CL enables them again. BUG=146619, 69941 Committed: https://crrev.com/0c1de4f2c2140d43f42f28ab64cc0c374d1c52d0 Cr-Commit-Position: refs/heads/master@{#316356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hichris123
pkasting@: Can you take a look at this CL? It re-enables two flaky or timing ...
5 years, 10 months ago (2015-02-14 01:09:06 UTC) #2
Peter Kasting
LGTM. Removing the bug comments is correct.
5 years, 10 months ago (2015-02-14 01:10:42 UTC) #3
hichris123
On 2015/02/14 01:10:42, Peter Kasting wrote: > LGTM. Removing the bug comments is correct. Quickest ...
5 years, 10 months ago (2015-02-14 01:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930453002/1
5 years, 10 months ago (2015-02-14 01:15:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 01:43:37 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 01:44:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c1de4f2c2140d43f42f28ab64cc0c374d1c52d0
Cr-Commit-Position: refs/heads/master@{#316356}

Powered by Google App Engine
This is Rietveld 408576698