Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 930423002: Disable WebGL conformance test on Win8/NVIDIA (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebGL conformance test on Win8/NVIDIA The test: conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view Has been timing out on and off for as long as we have records. BUG=459265 NOPRESUBMIT=True Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d Cr-Commit-Position: refs/heads/master@{#316872}

Patch Set 1 #

Patch Set 2 : git cl issue #

Patch Set 3 : Use win instead of win8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
ccameron
This is the change I was discussing -- the expectation line looks wrong, but I ...
5 years, 10 months ago (2015-02-17 20:51:28 UTC) #2
ccameron
(fixed name)
5 years, 10 months ago (2015-02-17 20:56:52 UTC) #3
Zhenyao Mo
On 2015/02/17 20:56:52, ccameron wrote: > (fixed name) LGTM
5 years, 10 months ago (2015-02-17 21:08:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930423002/20001
5 years, 10 months ago (2015-02-17 21:29:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43320)
5 years, 10 months ago (2015-02-17 21:36:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930423002/20001
5 years, 10 months ago (2015-02-17 21:37:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/33508)
5 years, 10 months ago (2015-02-17 22:42:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930423002/20001
5 years, 10 months ago (2015-02-18 02:04:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/33662)
5 years, 10 months ago (2015-02-18 03:05:11 UTC) #16
ccameron
On 2015/02/18 03:05:11, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-18 16:41:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930423002/40001
5 years, 10 months ago (2015-02-18 16:42:35 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/48531)
5 years, 10 months ago (2015-02-18 17:29:36 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930423002/40001
5 years, 10 months ago (2015-02-18 18:55:12 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-18 19:21:51 UTC) #25
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d Cr-Commit-Position: refs/heads/master@{#316872}
5 years, 10 months ago (2015-02-18 19:22:33 UTC) #26
hendrikw
5 years, 8 months ago (2015-04-14 22:22:10 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1085073002/ by hendrikw@chromium.org.

The reason for reverting is: kbr@ doesn't think this is needed anymore, and it
might be a cause of us missing real issues.  I'll try reverting it, and keep an
eye on it..

Powered by Google App Engine
This is Rietveld 408576698