Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 930403002: Remove remoting::Clipboard::Stop(). (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
Lambros
CC:
chromium-reviews, stevenjb+watch_chromium.org, dcheng, oshima+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remoting::Clipboard::Stop(). Clipboard is single-threaded, so Stop() is not useful there. Committed: https://crrev.com/45f92d83826113bb931988eb53c23d94cb4f152c Cr-Commit-Position: refs/heads/master@{#316952}

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -43 lines) Patch
M remoting/host/chromeos/clipboard_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/chromeos/clipboard_aura.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M remoting/host/chromeos/clipboard_aura_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/clipboard.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/clipboard_mac.mm View 2 chunks +0 lines, -6 lines 0 comments Download
M remoting/host/clipboard_win.cc View 1 3 chunks +6 lines, -10 lines 0 comments Download
M remoting/host/clipboard_x11.cc View 1 3 chunks +2 lines, -12 lines 0 comments Download
M remoting/host/input_injector_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/input_injector_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/input_injector_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Sergey Ulanov
5 years, 10 months ago (2015-02-17 20:06:15 UTC) #2
Lambros
lgtm https://codereview.chromium.org/930403002/diff/1/remoting/host/clipboard_win.cc File remoting/host/clipboard_win.cc (right): https://codereview.chromium.org/930403002/diff/1/remoting/host/clipboard_win.cc#newcode110 remoting/host/clipboard_win.cc:110: ~Clipboard() override; ~ClipboardWin() ? I didn't know C++ ...
5 years, 10 months ago (2015-02-17 21:37:33 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/930403002/diff/1/remoting/host/clipboard_win.cc File remoting/host/clipboard_win.cc (right): https://codereview.chromium.org/930403002/diff/1/remoting/host/clipboard_win.cc#newcode110 remoting/host/clipboard_win.cc:110: ~Clipboard() override; On 2015/02/17 21:37:33, Lambros wrote: > ~ClipboardWin() ...
5 years, 10 months ago (2015-02-17 23:51:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930403002/20001
5 years, 10 months ago (2015-02-18 19:07:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/27704)
5 years, 10 months ago (2015-02-18 19:36:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930403002/40001
5 years, 10 months ago (2015-02-19 00:54:06 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 01:24:36 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:25:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/45f92d83826113bb931988eb53c23d94cb4f152c
Cr-Commit-Position: refs/heads/master@{#316952}

Powered by Google App Engine
This is Rietveld 408576698