Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 930373006: [Android] Restore filter specs to AdbWrapper.Logcat and LogcatMonitor. (Closed)

Created:
5 years, 10 months ago by jbudorick
Modified:
5 years, 10 months ago
Reviewers:
perezju, petrcermak
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Restore filter specs to AdbWrapper.Logcat and LogcatMonitor. BUG=459672 Committed: https://crrev.com/1860e5f6b74eee2e2c5b5f9bbcea3f79aa3b17d7 Cr-Commit-Position: refs/heads/master@{#317069}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M build/android/pylib/device/adb_wrapper.py View 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/device/logcat_monitor.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M build/android/pylib/linker/test_case.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
5 years, 10 months ago (2015-02-19 04:50:42 UTC) #2
perezju
On 2015/02/19 04:50:42, jbudorick wrote: lgtm
5 years, 10 months ago (2015-02-19 09:54:55 UTC) #3
petrcermak
LGTM. Thanks for taking care of this :-)
5 years, 10 months ago (2015-02-19 10:32:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930373006/20001
5 years, 10 months ago (2015-02-19 16:00:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 17:39:02 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 17:39:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1860e5f6b74eee2e2c5b5f9bbcea3f79aa3b17d7
Cr-Commit-Position: refs/heads/master@{#317069}

Powered by Google App Engine
This is Rietveld 408576698