Remove adapter method on HistoryBackend delegating to AndroidProviderBackend

Remove adapter method on HistoryBackend delegating to AndroidProviderBackend

In order to remove the dependency of HistoryBackend on AndroidProviderBackend,
remove the adapter method that just forward their implementation to it. Also
remove methods that advance or delete a AndroidStatement as they do depend on
the HistoryBackend.

Convert the adapter method in adapter free function wrapped in HistoryDBTask
so that the code only use the public API of HistoryService and HistoryBackend.

Return the base::CancelableTaskTracker::TaskId from the ScheduleDBTask method
on HistoryService so that AndroidHistoryProviderService can return it and the
task be properly cancellable.

BUG=453790
Committed: https://crrev.com/3983849f247fcc47e0c05430b81d6481453c804e
Cr-Commit-Position: refs/heads/master@{#317331}

[sdefresne, 2015-02-17 18:11:07]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2015-02-17 18:11:08]

PTAL

[droger, 2015-02-18 14:04:01]

Looks good in general.

https://codereview.chromium.org/930363002/diff/1/chrome/browser/history/andro...
File chrome/browser/history/android/android_history_provider_service.cc (right):

https://codereview.chromium.org/930363002/diff/1/chrome/browser/history/andro...
chrome/browser/history/android/android_history_provider_service.cc:31: :
request_cb_(request_cb), result_cb_(result_cb), result_(ResultType{}) {
ResultType{}:
That "(Uniform) Initialization Syntax" seems banned for now:
https://chromium-cpp.appspot.com/

[sdefresne, 2015-02-18 14:48:11]

PTAL

[droger, 2015-02-18 14:56:51]

lgtm

[sdefresne, 2015-02-18 15:16:12]

New patchsets have been uploaded after l-g-t-m from droger@chromium.org

[sdefresne, 2015-02-18 15:19:26]

sdefresne@chromium.org changed reviewers:
+ zea@chromium.org

[sdefresne, 2015-02-18 15:19:27]

zea: I need OWNERS approval for
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

[sdefresne, 2015-02-20 10:28:13]

sdefresne@chromium.org changed reviewers:
+ atwilson@chromium.org
- zea@chromium.org

[sdefresne, 2015-02-20 10:28:30]

atwilson@chromium.org: could you review chrome/browser/sync as an OWNERS?

[Andrew T Wilson (Slow), 2015-02-20 10:45:03]

LGTM with one question/comment.

https://codereview.chromium.org/930363002/diff/40001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service_typed_url_unittest.cc (right):

https://codereview.chromium.org/930363002/diff/40001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc:129: return
base::CancelableTaskTracker::kBadTaskId;
I don't understand why it's OK to return a non-valid task ID here - can you add
a comment?

[sdefresne, 2015-02-20 10:48:14]

https://codereview.chromium.org/930363002/diff/40001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service_typed_url_unittest.cc (right):

https://codereview.chromium.org/930363002/diff/40001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc:129: return
base::CancelableTaskTracker::kBadTaskId;
On 2015/02/20 at 10:45:03, Andrew T Wilson wrote:
> I don't understand why it's OK to return a non-valid task ID here - can you
add a comment?

The only code using the TaskId to cancel a ScheduledDBTask is android specific
code called from android_history_provider_service.cc that is not running during
those unit tests. The return value is unused for all the unit tests.

[sdefresne, 2015-02-20 10:49:43]

New patchsets have been uploaded after l-g-t-m from atwilson@chromium.org

[sdefresne, 2015-02-20 16:14:03]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-02-20 16:14:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930363002/60001

[commit-bot: I haz the power, 2015-02-20 16:18:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-20 16:18:48]

Patchset 4 (id:??) landed as
https://crrev.com/3983849f247fcc47e0c05430b81d6481453c804e
Cr-Commit-Position: refs/heads/master@{#317331}