Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 930343002: Move inactive telemetry reviewers to emeritus (Closed)

Created:
5 years, 10 months ago by sullivan
Modified:
5 years, 10 months ago
Reviewers:
nednguyen, nduca, tonyg, marja
CC:
chromium-reviews, telemetry-reviews_chromium.org, chrishenry, marja, nduca, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move inactive telemetry reviewers to emeritus Committed: https://crrev.com/fb08a0fa2c10544e102bcadeadd08c6815055752 Cr-Commit-Position: refs/heads/master@{#316603}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/telemetry/OWNERS View 1 chunk +5 lines, -5 lines 1 comment Download

Messages

Total messages: 16 (5 generated)
sullivan
5 years, 10 months ago (2015-02-17 16:51:19 UTC) #2
nednguyen
5 years, 10 months ago (2015-02-17 16:53:27 UTC) #4
nduca
lgtm :)
5 years, 10 months ago (2015-02-17 16:54:16 UTC) #5
nednguyen
lgtm
5 years, 10 months ago (2015-02-17 16:54:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930343002/1
5 years, 10 months ago (2015-02-17 16:55:52 UTC) #8
nednguyen
On 2015/02/17 16:55:52, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 10 months ago (2015-02-17 17:03:40 UTC) #9
tonyg
lgtm https://codereview.chromium.org/930343002/diff/1/tools/telemetry/OWNERS File tools/telemetry/OWNERS (right): https://codereview.chromium.org/930343002/diff/1/tools/telemetry/OWNERS#newcode15 tools/telemetry/OWNERS:15: # emeritus: s/emeritus/emeriti/ ;)
5 years, 10 months ago (2015-02-17 17:19:47 UTC) #11
marja
lgtm
5 years, 10 months ago (2015-02-17 17:40:26 UTC) #13
sullivan
On 2015/02/17 17:03:40, nednguyen wrote: > On 2015/02/17 16:55:52, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-17 17:51:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 17:54:39 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 17:55:44 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fb08a0fa2c10544e102bcadeadd08c6815055752
Cr-Commit-Position: refs/heads/master@{#316603}

Powered by Google App Engine
This is Rietveld 408576698