Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: tools/perf/unit-info.json

Issue 930333002: [telemetry] Add new measurement that counts number of GCs needed to free V8 context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from Ross Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/unit-info.json
diff --git a/tools/perf/unit-info.json b/tools/perf/unit-info.json
index 6a89b0680e48e56f1be9b61a09451f7295f1b878..c228c447a9eddaa6f75c53a1fb4268cbdd86448a 100644
--- a/tools/perf/unit-info.json
+++ b/tools/perf/unit-info.json
@@ -55,6 +55,10 @@
"frame_time": {
"improvement_direction": "down"
},
+ "garbage_collections": {
+ "improvement_direction": "down",
+ "why": "Number of GCs needed to collect an object. Less is better."
+ },
"Hz": {
"improvement_direction": "up",
"why": "Higher frequencies are faster."

Powered by Google App Engine
This is Rietveld 408576698