Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: tools/perf/page_sets/page_reload_cases.py

Issue 930333002: [telemetry] Add new measurement that counts number of GCs needed to free V8 context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2014 The Chromium Authors. All rights reserved.
Sami 2015/02/17 17:14:06 year++
ulan 2015/02/18 10:35:56 Done.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4 from telemetry.page import page as page_module
5 from telemetry.page import page_set as page_set_module
6
7 from page_sets import top_pages
8
9
10 def _Reload(action_runner):
11 for _ in xrange(10):
12 action_runner.ReloadPage()
13 action_runner.Wait(2)
Sami 2015/02/17 17:14:06 Any significance to the two seconds here? Is there
ulan 2015/02/18 10:35:56 2 seconds is just an arbitrary number. Is it possi
Sami 2015/02/18 15:30:26 ReloadPage() already waits for the page to become
ulan 2015/02/18 15:58:41 I see. OK, let's leave it.
14
15
16 def _CreatePageClassWithReload(page_cls):
17 class DerivedSmoothPage(page_cls): # pylint: disable=W0232
18
19 def RunPageInteractions(self, action_runner):
20 _Reload(action_runner)
21 return DerivedSmoothPage
22
Sami 2015/02/17 17:14:06 nit: add an extra blank line here.
ulan 2015/02/18 10:35:56 Done.
23 class PageReloadCasesPageSet(page_set_module.PageSet):
24
25 """ Pages for testing GC efficiency on page reload. """
26
27 def __init__(self):
28 super(PageReloadCasesPageSet, self).__init__(
29 user_agent_type='desktop',
30 archive_data_file='data/page_reload_cases.json',
Sami 2015/02/17 17:14:06 I think we can reuse the top_pages archive file he
ulan 2015/02/18 10:35:56 Done.
31 bucket=page_set_module.PARTNER_BUCKET)
32
33 self.AddUserStory(_CreatePageClassWithReload(
34 top_pages.GoogleWebSearchPage)(self))
35 self.AddUserStory(_CreatePageClassWithReload(
36 top_pages.GmailPage)(self))
37 self.AddUserStory(_CreatePageClassWithReload(
38 top_pages.GoogleCalendarPage)(self))
39 self.AddUserStory(_CreatePageClassWithReload(
40 top_pages.GoogleDocPage)(self))
41 self.AddUserStory(_CreatePageClassWithReload(
42 top_pages.GooglePlusPage)(self))
43 self.AddUserStory(_CreatePageClassWithReload(
44 top_pages.YoutubePage)(self))
45 self.AddUserStory(_CreatePageClassWithReload(
46 top_pages.WordpressPage)(self))
47 self.AddUserStory(_CreatePageClassWithReload(
48 top_pages.FacebookPage)(self))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698