Upstream iOS' Open from Clipboard component.

Upstream iOS' Open from Clipboard component.

The component's goal is to provide omnibox suggestions based on the
clipboard's content.

BUG=None.

Committed: https://crrev.com/9021d87d62b29e0b1ee4625ad0006b500cc3f683
Cr-Commit-Position: refs/heads/master@{#317055}

[jif-google, 2015-02-17 16:44:19]

jif@google.com changed reviewers:
+ sdefresne@chromium.org

[jif, 2015-02-17 16:45:16]

ptal

[sdefresne, 2015-02-18 10:20:32]

Could you expend the description to explain what is the purpose of the
component?

https://codereview.chromium.org/930323003/diff/20001/components/open_from_cli...
File components/open_from_clipboard/clipboard_url_provider.cc (right):

https://codereview.chromium.org/930323003/diff/20001/components/open_from_cli...
components/open_from_clipboard/clipboard_url_provider.cc:49:
base::UTF8ToUTF16(l10n_util::GetStringUTF8(IDS_LINK_FROM_CLIPBOARD)));
Please use l10n_util::GetStringUTF16() to avoid the following conversions IDS ->
UTF16 -> UTF8 -> UTF16.

[jif, 2015-02-18 14:55:17]

jif@chromium.org changed reviewers:
+ jshin@chromium.org, stuartmorgan@chromium.org

[jif, 2015-02-18 14:55:17]

+jshin OWNER of +ui/base/l10n
+stuartmorgan@chromium.org OWNER of +build/ios

[sdefresne, 2015-02-18 15:10:07]

lgtm with nit

https://codereview.chromium.org/930323003/diff/60001/components/open_from_cli...
File components/open_from_clipboard/clipboard_url_provider.cc (right):

https://codereview.chromium.org/930323003/diff/60001/components/open_from_cli...
components/open_from_clipboard/clipboard_url_provider.cc:43:
match.contents.assign(base::UTF8ToUTF16(url.possibly_invalid_spec()));
nit: since you ensure that GetRecentURLFromClipboard() returns a valid GURL, I
think you can use url.spec().

https://codereview.chromium.org/930323003/diff/60001/components/open_from_cli...
components/open_from_clipboard/clipboard_url_provider.cc:43:
match.contents.assign(base::UTF8ToUTF16(url.possibly_invalid_spec()));
nit: since you ensure that GetRecentURLFromClipboard() returns a valid GURL, I
think you can use url.spec().

[stuartmorgan, 2015-02-18 16:08:17]

build/ios/ LGTM

(I'd happily LGTM a CL that owner-wildcarded that file, BTW)

[sdefresne, 2015-02-18 16:37:24]

On 2015/02/18 at 16:08:17, stuartmorgan wrote:
> build/ios/ LGTM
> 
> (I'd happily LGTM a CL that owner-wildcarded that file, BTW)

You asked for it, you'll just have to l-g-t-m then:
https://codereview.chromium.org/934163005

[jungshik at Google, 2015-02-18 20:15:22]

LGTM for DEPS change (l10n)

[jif, 2015-02-18 20:18:10]

The CQ bit was checked by jif@chromium.org

[jif, 2015-02-18 20:18:19]

The CQ bit was unchecked by jif@chromium.org

[jif, 2015-02-18 20:20:33]

New patchsets have been uploaded after l-g-t-m from
sdefresne@chromium.org,stuartmorgan@chromium.org,jshin@chromium.org

[jif, 2015-02-18 20:20:40]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2015-02-18 20:21:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930323003/80001

[commit-bot: I haz the power, 2015-02-18 20:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 20:27:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2015-02-18 21:43:28]

On 2015/02/18 at 20:27:33, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

** Presubmit Warnings **
File components/open_from_clipboard/clipboard_recent_content_ios.mm line 107:
MobileOmniboxClipboardChanged is missing in tools/metrics/actions/actions.xml.
Please run tools/metrics/actions/extract_actions.py to update.

[jif, 2015-02-19 08:20:52]

jif@chromium.org changed reviewers:
+ asvitkine@chromium.org

[jif, 2015-02-19 08:22:36]

+asvitkine OWNER of tools/metrics/
The change in actions.xml is an upstreaming of
https://critique.corp.google.com/#review/84623919.

[Alexei Svitkine (slow), 2015-02-19 14:48:24]

On 2015/02/19 08:22:36, jif wrote:
> +asvitkine OWNER of tools/metrics/
> The change in actions.xml is an upstreaming of
> https://critique.corp.google.com/#review/84623919.

LGTM, but please also send me an internal CL to remove the entry from the
internal file and submit it after this lands. Thanks!

[jif, 2015-02-19 14:51:34]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2015-02-19 14:51:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930323003/100001

[commit-bot: I haz the power, 2015-02-19 15:40:31]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-19 15:41:09]

Patchset 6 (id:??) landed as
https://crrev.com/9021d87d62b29e0b1ee4625ad0006b500cc3f683
Cr-Commit-Position: refs/heads/master@{#317055}