Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: Source/core/fetch/ResourceFetcher.cpp

Issue 930323002: Upgrade: Send a 'Prefer' header for feature detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rename? Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/ResourceFetcher.h ('k') | Source/core/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/ResourceFetcher.cpp
diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp
index dcd0a108d52cbf611f2fcf8a3ba4072956b3cf14..545e1660664995f4046375b2398adba5bc1e7955 100644
--- a/Source/core/fetch/ResourceFetcher.cpp
+++ b/Source/core/fetch/ResourceFetcher.cpp
@@ -719,7 +719,7 @@ ResourcePtr<Resource> ResourceFetcher::requestResource(Resource::Type type, Fetc
TRACE_EVENT0("blink", "ResourceFetcher::requestResource");
- maybeUpgradeInsecureRequestURL(request);
+ upgradeInsecureRequest(request);
KURL url = request.resourceRequest().url();
@@ -901,12 +901,18 @@ void ResourceFetcher::addAdditionalRequestHeaders(ResourceRequest& request, Reso
context().addAdditionalRequestHeaders(document(), request, (type == Resource::MainResource) ? FetchMainResource : FetchSubresource);
}
-void ResourceFetcher::maybeUpgradeInsecureRequestURL(FetchRequest& fetchRequest)
+void ResourceFetcher::upgradeInsecureRequest(FetchRequest& fetchRequest)
{
- if (!m_document)
+ if (!m_document || !RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled())
return;
KURL url = fetchRequest.resourceRequest().url();
+
+ // Tack a 'Prefer' header to outgoing navigational requests, as described in
+ // https://w3c.github.io/webappsec/specs/upgrade/#feature-detect
+ if (fetchRequest.resourceRequest().frameType() != WebURLRequest::FrameTypeNone && !SecurityOrigin::isSecure(url))
+ fetchRequest.mutableResourceRequest().addHTTPHeaderField("Prefer", "return=secure-representation");
+
if (m_document->insecureContentPolicy() == SecurityContext::InsecureContentUpgrade && url.protocolIs("http")) {
// We always upgrade subresource requests and nested frames, we always upgrade form
// submissions, and we always upgrade requests whose host matches the host of the
« no previous file with comments | « Source/core/fetch/ResourceFetcher.h ('k') | Source/core/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698