Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 930293002: [strong] Remove mjsunit/strong/use-strong-flag.js (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Remove mjsunit/strong/use-strong-flag.js It would force us to make mjsunit.js strong-compatible, and that's too much for now (for the upcoming features) and would have a ripple effect on other tests. Especially debug-script.js which unships harmony features would break. R=rossberg@chromium.org BUG= Committed: https://crrev.com/7c15df8144ff1b164022a798fa38b5acb057a82f Cr-Commit-Position: refs/heads/master@{#26694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
D test/mjsunit/strong/use-strong-flag.js View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rossberg
lgtm
5 years, 10 months ago (2015-02-17 14:43:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930293002/1
5 years, 10 months ago (2015-02-17 14:44:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 15:11:05 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 15:11:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c15df8144ff1b164022a798fa38b5acb057a82f
Cr-Commit-Position: refs/heads/master@{#26694}

Powered by Google App Engine
This is Rietveld 408576698