gyp/codec.gyp - Issue 930283002: Add SkCodec, including PNG implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/codec.gyp

Issue 930283002: Add SkCodec, including PNG implementation. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Make SkPngCodec work on Mac! Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # GYP file for codec project.

	2 {

	3 'targets': [

	4 {

	5 'target_name': 'codec',

	6 'product_name': 'skia_codec',

	7 'type': 'static_library',

	8 'standalone_static_library': 1,

	9 'dependencies': [

	10 'core.gyp:*',

	11 'libjpeg.gyp:*',

	12 'etc1.gyp:libetc1',

	13 'ktx.gyp:libSkKTX',

	14 'libwebp.gyp:libwebp',

	15 'utils.gyp:utils',

	16 ],

	17 'include_dirs': [

	18 '../include/codec',

	19 '../src/codec',

	20 ],

	21 'sources': [

	22 '../src/codec/SkCodec.cpp',

	23 '../src/codec/SkCodec_libpng.cpp',

	24 '../src/codec/SkSwizzler.cpp',

	25 ],

	26 'conditions': [

	27 [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "android", "mac ", "ios"]', {
	djsollen 2015/02/25 20:52:15 I think you can remove this condition and the one I think you can remove this condition and the one below it and just make it a constant dependency. scroggo 2015/02/25 21:33:52 Done. This explains my Windows trybot failure, I t Show quoted text On 2015/02/25 20:52:15, djsollen wrote: > I think you can remove this condition and the one below it and just make it a > constant dependency. Done. This explains my Windows trybot failure, I think...
	28 'dependencies': [

	29 'libpng.gyp:libpng',
	djsollen 2015/02/25 20:52:15 this gyp file still uses the android_deps.gyp inte this gyp file still uses the android_deps.gyp internally unless you set the skia_libpng_static variable. Not sure if you can set it here and have it be picked up by the dependency or not. scroggo 2015/02/25 21:33:52 I set it in common_variables. Show quoted text On 2015/02/25 20:52:15, djsollen wrote: > this gyp file still uses the android_deps.gyp internally unless you set the > skia_libpng_static variable. Not sure if you can set it here and have it be > picked up by the dependency or not. I set it in common_variables.
	30 ],

	31 }],

	32 [ 'skia_os == "chromeos"', {

	33 'dependencies': [

	34 'libpng.gyp:libpng',

	35 ],

	36 }],

	37 [ 'skia_os == "ios"', {

	38 'include_dirs': [

	39 '../include/utils/mac',
	djsollen 2015/02/25 20:52:15 is this needed? is this needed? scroggo 2015/02/25 21:33:52 No. Removed. Show quoted text On 2015/02/25 20:52:15, djsollen wrote: > is this needed? No. Removed.
	40 ],

	41 }],

	42 ],

	43 'direct_dependent_settings': {

	44 'include_dirs': [

	45 '../include/codec',

	46 ],

	47 },

	48 },

	49 ],

	50 }

OLD	NEW

« DEPS ('K') | « dm/DMSrcSink.cpp ('k') | gyp/common_variables.gypi » ('j') | no next file with comments »