Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: shell/android/ui_application_loader_android.h

Issue 930243006: Simplify the ApplicationLoader interface in preparation for changes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: ptal Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/android/native_viewport_application_loader.cc ('k') | shell/android/ui_application_loader_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/ui_application_loader_android.h
diff --git a/shell/android/ui_application_loader_android.h b/shell/android/ui_application_loader_android.h
index e7933c60e08b9605156a7297ae9ef9b7ac8a995a..06ccc09c8e9aa3a3c0dd0df4d60a9dbf9a127b21 100644
--- a/shell/android/ui_application_loader_android.h
+++ b/shell/android/ui_application_loader_android.h
@@ -27,10 +27,8 @@ class UIApplicationLoader : public ApplicationLoader {
~UIApplicationLoader() override;
// ApplicationLoader overrides:
- void Load(ApplicationManager* manager,
- const GURL& url,
- InterfaceRequest<Application> application_request,
- LoadCallback callback) override;
+ void Load(const GURL& url,
+ InterfaceRequest<Application> application_request) override;
void OnApplicationError(ApplicationManager* manager,
const GURL& url) override;
@@ -41,8 +39,7 @@ class UIApplicationLoader : public ApplicationLoader {
// to |background_loader_| to do the actual loading.
// TODO: having this code take a |manager| is fragile (as ApplicationManager
// isn't thread safe).
- void LoadOnUIThread(ApplicationManager* manager,
- const GURL& url,
+ void LoadOnUIThread(const GURL& url,
InterfaceRequest<Application> application_request);
void OnApplicationErrorOnUIThread(ApplicationManager* manager,
const GURL& url);
« no previous file with comments | « shell/android/native_viewport_application_loader.cc ('k') | shell/android/ui_application_loader_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698