Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1871)

Unified Diff: shell/android/background_application_loader.h

Issue 930243006: Simplify the ApplicationLoader interface in preparation for changes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: ptal Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/android/android_handler_loader.cc ('k') | shell/android/background_application_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/background_application_loader.h
diff --git a/shell/android/background_application_loader.h b/shell/android/background_application_loader.h
index a4c07b84df2e2c14073437a774d712c423197607..850b9009a20e3fd9757f7e7cebb6aa02eedfb414 100644
--- a/shell/android/background_application_loader.h
+++ b/shell/android/background_application_loader.h
@@ -24,10 +24,8 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundApplicationLoader
~BackgroundApplicationLoader() override;
// ApplicationLoader overrides:
- void Load(ApplicationManager* manager,
- const GURL& url,
- InterfaceRequest<Application> application_request,
- LoadCallback callback) override;
+ void Load(const GURL& url,
+ InterfaceRequest<Application> application_request) override;
void OnApplicationError(ApplicationManager* manager,
const GURL& url) override;
@@ -37,10 +35,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundApplicationLoader
// These functions are exected on the background thread. They call through
// to |background_loader_| to do the actual loading.
- // TODO: having this code take a |manager| is fragile (as ApplicationManager
- // isn't thread safe).
void LoadOnBackgroundThread(
- ApplicationManager* manager,
const GURL& url,
InterfaceRequest<Application> application_request);
void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager,
« no previous file with comments | « shell/android/android_handler_loader.cc ('k') | shell/android/background_application_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698