Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: shell/android/background_application_loader.cc

Issue 930243006: Simplify the ApplicationLoader interface in preparation for changes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: ptal Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/android/background_application_loader.cc
diff --git a/shell/android/background_application_loader.cc b/shell/android/background_application_loader.cc
index 8f3c21b2abdffec41444d96dfdd4449f5f1be45d..23895152f6ddbef2a65f38f37a13b754b7d716f4 100644
--- a/shell/android/background_application_loader.cc
+++ b/shell/android/background_application_loader.cc
@@ -26,10 +26,8 @@ BackgroundApplicationLoader::~BackgroundApplicationLoader() {
}
void BackgroundApplicationLoader::Load(
- ApplicationManager* manager,
const GURL& url,
- InterfaceRequest<Application> application_request,
- LoadCallback callback) {
+ InterfaceRequest<Application> application_request) {
DCHECK(application_request.is_pending());
if (!thread_) {
// TODO(tim): It'd be nice if we could just have each Load call
@@ -47,7 +45,7 @@ void BackgroundApplicationLoader::Load(
task_runner_->PostTask(
FROM_HERE,
base::Bind(&BackgroundApplicationLoader::LoadOnBackgroundThread,
- base::Unretained(this), manager, url,
+ base::Unretained(this), url,
base::Passed(&application_request)));
}
@@ -74,11 +72,10 @@ void BackgroundApplicationLoader::Run() {
}
void BackgroundApplicationLoader::LoadOnBackgroundThread(
- ApplicationManager* manager,
const GURL& url,
InterfaceRequest<Application> application_request) {
DCHECK(task_runner_->RunsTasksOnCurrentThread());
- loader_->Load(manager, url, application_request.Pass(), SimpleLoadCallback());
+ loader_->Load(url, application_request.Pass());
}
void BackgroundApplicationLoader::OnApplicationErrorOnBackgroundThread(
« no previous file with comments | « shell/android/background_application_loader.h ('k') | shell/android/background_application_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698