Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: shell/context.cc

Issue 930243006: Simplify the ApplicationLoader interface in preparation for changes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: trybot debugging ftw Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "shell/context.h" 5 #include "shell/context.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/base_switches.h" 9 #include "base/base_switches.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 base::Unretained(&application_manager_))); 251 base::Unretained(&application_manager_)));
252 } 252 }
253 253
254 scoped_ptr<DynamicServiceRunnerFactory> runner_factory; 254 scoped_ptr<DynamicServiceRunnerFactory> runner_factory;
255 if (command_line->HasSwitch(switches::kEnableMultiprocess)) 255 if (command_line->HasSwitch(switches::kEnableMultiprocess))
256 runner_factory.reset(new OutOfProcessDynamicServiceRunnerFactory()); 256 runner_factory.reset(new OutOfProcessDynamicServiceRunnerFactory());
257 else 257 else
258 runner_factory.reset(new InProcessDynamicServiceRunnerFactory()); 258 runner_factory.reset(new InProcessDynamicServiceRunnerFactory());
259 259
260 DynamicApplicationLoader* dynamic_application_loader = 260 DynamicApplicationLoader* dynamic_application_loader =
261 new DynamicApplicationLoader(this, runner_factory.Pass()); 261 new DynamicApplicationLoader(this, runner_factory.Pass());
qsr 2015/02/19 09:25:01 Maybe: scoped_ptr<DynamicApplicationLoader> dynam
Aaron Boodman 2015/02/19 20:38:46 Done.
262 InitContentHandlers(dynamic_application_loader, command_line); 262 InitContentHandlers(dynamic_application_loader, command_line);
263 application_manager_.set_default_loader( 263 application_manager_.set_dynamic_application_loader(
264 scoped_ptr<ApplicationLoader>(dynamic_application_loader)); 264 scoped_ptr<DynamicApplicationLoader>(dynamic_application_loader));
265 265
266 ServiceProviderPtr tracing_service_provider_ptr; 266 ServiceProviderPtr tracing_service_provider_ptr;
267 new TracingServiceProvider(GetProxy(&tracing_service_provider_ptr)); 267 new TracingServiceProvider(GetProxy(&tracing_service_provider_ptr));
268 application_manager_.ConnectToApplication( 268 application_manager_.ConnectToApplication(
269 GURL("mojo:tracing"), GURL(""), nullptr, 269 GURL("mojo:tracing"), GURL(""), nullptr,
270 tracing_service_provider_ptr.Pass()); 270 tracing_service_provider_ptr.Pass());
271 271
272 if (listener_) 272 if (listener_)
273 listener_->WaitForListening(); 273 listener_->WaitForListening();
274 274
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 ScopedMessagePipeHandle Context::ConnectToServiceByName( 313 ScopedMessagePipeHandle Context::ConnectToServiceByName(
314 const GURL& application_url, 314 const GURL& application_url,
315 const std::string& service_name) { 315 const std::string& service_name) {
316 app_urls_.insert(application_url); 316 app_urls_.insert(application_url);
317 return application_manager_.ConnectToServiceByName(application_url, 317 return application_manager_.ConnectToServiceByName(application_url,
318 service_name).Pass(); 318 service_name).Pass();
319 } 319 }
320 320
321 } // namespace shell 321 } // namespace shell
322 } // namespace mojo 322 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698