Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: shell/native_application_loader_unittest.cc

Issue 930243006: Simplify the ApplicationLoader interface in preparation for changes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: ptal Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « shell/native_application_loader.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/scoped_temp_dir.h" 5 #include "base/files/scoped_temp_dir.h"
6 #include "shell/context.h" 6 #include "shell/context.h"
7 #include "shell/dynamic_application_loader.h"
8 #include "shell/dynamic_service_runner.h" 7 #include "shell/dynamic_service_runner.h"
9 #include "shell/filename_util.h" 8 #include "shell/filename_util.h"
9 #include "shell/native_application_loader.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace mojo { 12 namespace mojo {
13 namespace shell { 13 namespace shell {
14 14
15 namespace { 15 namespace {
16 16
17 struct TestState { 17 struct TestState {
18 TestState() 18 TestState()
19 : runner_was_created(false), 19 : runner_was_created(false),
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 return scoped_ptr<DynamicServiceRunner>( 53 return scoped_ptr<DynamicServiceRunner>(
54 new TestDynamicServiceRunner(state_)); 54 new TestDynamicServiceRunner(state_));
55 } 55 }
56 56
57 private: 57 private:
58 TestState* state_; 58 TestState* state_;
59 }; 59 };
60 60
61 } // namespace 61 } // namespace
62 62
63 class DynamicApplicationLoaderTest : public testing::Test { 63 class NativeApplicationLoaderTest : public testing::Test {
64 public: 64 public:
65 DynamicApplicationLoaderTest() {} 65 NativeApplicationLoaderTest() {}
66 ~DynamicApplicationLoaderTest() override {} 66 ~NativeApplicationLoaderTest() override {}
67 void SetUp() override { 67 void SetUp() override {
68 context_.Init(); 68 context_.Init();
69 scoped_ptr<DynamicServiceRunnerFactory> factory( 69 scoped_ptr<DynamicServiceRunnerFactory> factory(
70 new TestDynamicServiceRunnerFactory(&state_)); 70 new TestDynamicServiceRunnerFactory(&state_));
71 loader_.reset(new DynamicApplicationLoader(&context_, factory.Pass())); 71 loader_.reset(new NativeApplicationLoader(&context_, factory.Pass()));
72 } 72 }
73 73
74 protected: 74 protected:
75 Context context_; 75 Context context_;
76 base::MessageLoop loop_; 76 base::MessageLoop loop_;
77 scoped_ptr<DynamicApplicationLoader> loader_; 77 scoped_ptr<NativeApplicationLoader> loader_;
78 TestState state_; 78 TestState state_;
79 }; 79 };
80 80
81 TEST_F(DynamicApplicationLoaderTest, DoesNotExist) { 81 TEST_F(NativeApplicationLoaderTest, DoesNotExist) {
82 base::ScopedTempDir temp_dir; 82 base::ScopedTempDir temp_dir;
83 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 83 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
84 base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt")); 84 base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));
85 GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file))); 85 GURL url(FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));
86 ApplicationPtr application; 86 ApplicationPtr application;
87 loader_->Load(context_.application_manager(), url, GetProxy(&application), 87 loader_->Load(url, GetProxy(&application),
88 ApplicationLoader::SimpleLoadCallback()); 88 NativeApplicationLoader::SimpleLoadCallback());
89 EXPECT_FALSE(state_.runner_was_created); 89 EXPECT_FALSE(state_.runner_was_created);
90 EXPECT_FALSE(state_.runner_was_started); 90 EXPECT_FALSE(state_.runner_was_started);
91 EXPECT_FALSE(state_.runner_was_destroyed); 91 EXPECT_FALSE(state_.runner_was_destroyed);
92 } 92 }
93 93
94 } // namespace shell 94 } // namespace shell
95 } // namespace mojo 95 } // namespace mojo
OLDNEW
« no previous file with comments | « shell/native_application_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698