Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: shell/android/ui_application_loader_android.cc

Issue 930243006: Simplify the ApplicationLoader interface in preparation for changes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: ptal Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "shell/android/ui_application_loader_android.h" 5 #include "shell/android/ui_application_loader_android.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "shell/application_manager/application_manager.h" 9 #include "shell/application_manager/application_manager.h"
10 10
11 namespace mojo { 11 namespace mojo {
12 12
13 UIApplicationLoader::UIApplicationLoader( 13 UIApplicationLoader::UIApplicationLoader(
14 scoped_ptr<ApplicationLoader> real_loader, 14 scoped_ptr<ApplicationLoader> real_loader,
15 base::MessageLoop* ui_message_loop) 15 base::MessageLoop* ui_message_loop)
16 : loader_(real_loader.Pass()), ui_message_loop_(ui_message_loop) { 16 : loader_(real_loader.Pass()), ui_message_loop_(ui_message_loop) {
17 } 17 }
18 18
19 UIApplicationLoader::~UIApplicationLoader() { 19 UIApplicationLoader::~UIApplicationLoader() {
20 ui_message_loop_->PostTask( 20 ui_message_loop_->PostTask(
21 FROM_HERE, base::Bind(&UIApplicationLoader::ShutdownOnUIThread, 21 FROM_HERE, base::Bind(&UIApplicationLoader::ShutdownOnUIThread,
22 base::Unretained(this))); 22 base::Unretained(this)));
23 } 23 }
24 24
25 void UIApplicationLoader::Load( 25 void UIApplicationLoader::Load(
26 ApplicationManager* manager,
27 const GURL& url, 26 const GURL& url,
28 InterfaceRequest<Application> application_request, 27 InterfaceRequest<Application> application_request) {
29 LoadCallback callback) {
30 DCHECK(application_request.is_pending()); 28 DCHECK(application_request.is_pending());
31 ui_message_loop_->PostTask( 29 ui_message_loop_->PostTask(
32 FROM_HERE, 30 FROM_HERE,
33 base::Bind(&UIApplicationLoader::LoadOnUIThread, base::Unretained(this), 31 base::Bind(&UIApplicationLoader::LoadOnUIThread, base::Unretained(this),
34 manager, url, base::Passed(&application_request))); 32 url, base::Passed(&application_request)));
35 } 33 }
36 34
37 void UIApplicationLoader::OnApplicationError(ApplicationManager* manager, 35 void UIApplicationLoader::OnApplicationError(ApplicationManager* manager,
38 const GURL& url) { 36 const GURL& url) {
39 ui_message_loop_->PostTask( 37 ui_message_loop_->PostTask(
40 FROM_HERE, base::Bind(&UIApplicationLoader::OnApplicationErrorOnUIThread, 38 FROM_HERE, base::Bind(&UIApplicationLoader::OnApplicationErrorOnUIThread,
41 base::Unretained(this), manager, url)); 39 base::Unretained(this), manager, url));
42 } 40 }
43 41
44 void UIApplicationLoader::LoadOnUIThread( 42 void UIApplicationLoader::LoadOnUIThread(
45 ApplicationManager* manager,
46 const GURL& url, 43 const GURL& url,
47 InterfaceRequest<Application> application_request) { 44 InterfaceRequest<Application> application_request) {
48 loader_->Load(manager, url, application_request.Pass(), SimpleLoadCallback()); 45 loader_->Load(url, application_request.Pass());
49 } 46 }
50 47
51 void UIApplicationLoader::OnApplicationErrorOnUIThread( 48 void UIApplicationLoader::OnApplicationErrorOnUIThread(
52 ApplicationManager* manager, 49 ApplicationManager* manager,
53 const GURL& url) { 50 const GURL& url) {
54 loader_->OnApplicationError(manager, url); 51 loader_->OnApplicationError(manager, url);
55 } 52 }
56 53
57 void UIApplicationLoader::ShutdownOnUIThread() { 54 void UIApplicationLoader::ShutdownOnUIThread() {
58 // Destroy |loader_| on the thread it's actually used on. 55 // Destroy |loader_| on the thread it's actually used on.
59 loader_.reset(); 56 loader_.reset();
60 } 57 }
61 58
62 } // namespace mojo 59 } // namespace mojo
OLDNEW
« no previous file with comments | « shell/android/ui_application_loader_android.h ('k') | shell/application_manager/application_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698