Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: PRESUBMIT.py

Issue 930243006: Simplify the ApplicationLoader interface in preparation for changes. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: ptal Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | services/window_manager/window_manager_api_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 868 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 return [] 879 return []
880 880
881 881
882 def _CheckSpamLogging(input_api, output_api): 882 def _CheckSpamLogging(input_api, output_api):
883 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS 883 file_inclusion_pattern = r'.+%s' % _IMPLEMENTATION_EXTENSIONS
884 black_list = (_EXCLUDED_PATHS + 884 black_list = (_EXCLUDED_PATHS +
885 _TEST_CODE_EXCLUDED_PATHS + 885 _TEST_CODE_EXCLUDED_PATHS +
886 input_api.DEFAULT_BLACK_LIST + 886 input_api.DEFAULT_BLACK_LIST +
887 (r"^base[\\\/]logging\.h$", 887 (r"^base[\\\/]logging\.h$",
888 r"^base[\\\/]logging\.cc$", 888 r"^base[\\\/]logging\.cc$",
889 r"^shell[\\\/]dynamic_application_loader\.cc$", 889 r"^shell[\\\/]native_application_loader\.cc$",
890 r"^sandbox[\\\/]linux[\\\/].*", 890 r"^sandbox[\\\/]linux[\\\/].*",
891 r"^tools[\\\/]", 891 r"^tools[\\\/]",
892 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",)) 892 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",))
893 source_file_filter = lambda x: input_api.FilterSourceFile( 893 source_file_filter = lambda x: input_api.FilterSourceFile(
894 x, white_list=(file_inclusion_pattern,), black_list=black_list) 894 x, white_list=(file_inclusion_pattern,), black_list=black_list)
895 895
896 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)") 896 log_macro = input_api.re.compile(r"\bD?LOG\s*\(\s*INFO\s*\)")
897 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,") 897 log_if_macro = input_api.re.compile(r"\bD?LOG_IF\s*\(\s*INFO\s*,")
898 printf_macro = input_api.re.compile(r"\bprintf\(") 898 printf_macro = input_api.re.compile(r"\bprintf\(")
899 fprintf_macro = input_api.re.compile(r"\bfprintf\((stdout|stderr)") 899 fprintf_macro = input_api.re.compile(r"\bfprintf\((stdout|stderr)")
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
1485 'Mojo ChromeOS Builder (dbg) Try', 1485 'Mojo ChromeOS Builder (dbg) Try',
1486 'Mojo ChromeOS Builder Try', 1486 'Mojo ChromeOS Builder Try',
1487 'Mojo Linux (dbg) Try', 1487 'Mojo Linux (dbg) Try',
1488 'Mojo Linux ASan Try', 1488 'Mojo Linux ASan Try',
1489 'Mojo Linux NaCl (dbg) Try', 1489 'Mojo Linux NaCl (dbg) Try',
1490 'Mojo Linux NaCl Try', 1490 'Mojo Linux NaCl Try',
1491 'Mojo Linux Try', 1491 'Mojo Linux Try',
1492 ] 1492 ]
1493 1493
1494 return GetDefaultTryConfigs(builders) 1494 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | services/window_manager/window_manager_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698