Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 930243002: Put extra information to the stack when crbug/454297 happens. (Closed)

Created:
5 years, 10 months ago by Igor Sheludko
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Put extra information to the stack when crbug/454297 happens. Committed: https://crrev.com/b85cd71002f7f092be4f4908a52ea5ffba84da50 Cr-Commit-Position: refs/heads/master@{#26683}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebasing and win64 compilation issue fix" #

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
M src/heap/mark-compact.cc View 1 2 2 chunks +97 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Igor Sheludko
PTAL
5 years, 10 months ago (2015-02-17 10:23:57 UTC) #2
Hannes Payer (out of office)
LGTM, one nit and windows compile errors. https://codereview.chromium.org/930243002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/930243002/diff/1/src/heap/mark-compact.cc#newcode2913 src/heap/mark-compact.cc:2913: index += ...
5 years, 10 months ago (2015-02-17 10:51:12 UTC) #3
Igor Sheludko
https://codereview.chromium.org/930243002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/930243002/diff/1/src/heap/mark-compact.cc#newcode2913 src/heap/mark-compact.cc:2913: index += 10; On 2015/02/17 10:51:11, Hannes Payer wrote: ...
5 years, 10 months ago (2015-02-17 10:57:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930243002/60001
5 years, 10 months ago (2015-02-17 11:19:48 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-17 11:23:36 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 11:23:50 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b85cd71002f7f092be4f4908a52ea5ffba84da50
Cr-Commit-Position: refs/heads/master@{#26683}

Powered by Google App Engine
This is Rietveld 408576698