Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 93023002: Remove ant_build_out. (Closed)

Created:
7 years ago by Nico
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Raphael Kubo da Costa (rakuco)
Visibility:
Public.

Description

Remove ant_build_out. build/java_apk,gypi defaults to something based on <(PRODUCT_DIR) for asset_location, so apparently it doesn't require an absolute path. Absolute paths are yucky, and the `pwd -P` pattern has led someone else astray, so remove it. BUG=none R=cjhopman@chromium.org TBR=avi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_android.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
7 years ago (2013-11-27 23:47:14 UTC) #1
cjhopman
This was originally used to handle relativization in ant build files. I'm quite happy to ...
7 years ago (2013-11-27 23:59:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/93023002/1
7 years ago (2013-11-28 03:45:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=38517
7 years ago (2013-11-28 04:03:12 UTC) #4
Nico
avi: tbr for content/OWNERS
7 years ago (2013-11-28 04:54:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/93023002/1
7 years ago (2013-11-28 04:55:00 UTC) #6
Nico
Committed patchset #1 manually as r237676 (presubmit successful).
7 years ago (2013-11-28 05:17:41 UTC) #7
Avi (use Gerrit)
7 years ago (2013-11-29 18:55:05 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698