Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 930223003: Do not reset ManifestManager state for same page navigation. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not reset ManifestManager state for same page navigation. BUG=459240 Committed: https://crrev.com/78a3ea3852d261b3dfc1069a06aec8323db0021d Cr-Commit-Position: refs/heads/master@{#316611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M content/browser/manifest/manifest_browsertest.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M content/renderer/manifest/manifest_manager.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-17 16:42:43 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 10 months ago (2015-02-17 16:51:40 UTC) #4
Miguel Garcia
lgtm
5 years, 10 months ago (2015-02-17 16:52:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930223003/1
5 years, 10 months ago (2015-02-17 16:53:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 18:22:02 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:22:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78a3ea3852d261b3dfc1069a06aec8323db0021d
Cr-Commit-Position: refs/heads/master@{#316611}

Powered by Google App Engine
This is Rietveld 408576698