Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 930213002: Report V8 execution termination in a worker as an error. (Closed)

Created:
5 years, 10 months ago by falken
Modified:
5 years, 10 months ago
Reviewers:
kinuko, haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, arv+blink, vivekg_samsung, tzik, nhiroki, falken, vivekg, blink-reviews-bindings_chromium.org, horo+watch_chromium.org, kinuko+serviceworker
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Report V8 execution termination in a worker as an error. If the execution was terminated during evaluation or event dispatch, consider that non-successful. No test added, it will be tested in the Chromium side change to terminate long-running Service Workers: https://codereview.chromium.org/912753002 BUG=372436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190553

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
falken
PTL... I think I'll wait until the branch cut for this change after all.
5 years, 10 months ago (2015-02-17 09:21:46 UTC) #2
kinuko
lgtm
5 years, 10 months ago (2015-02-17 16:50:55 UTC) #3
haraken
bindings/ LGTM
5 years, 10 months ago (2015-02-17 23:10:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930213002/1
5 years, 10 months ago (2015-02-20 07:59:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/28870)
5 years, 10 months ago (2015-02-20 08:04:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930213002/20001
5 years, 10 months ago (2015-02-20 08:45:20 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 11:31:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190553

Powered by Google App Engine
This is Rietveld 408576698