Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 930203004: Fix en_GB's language name failure (Closed)

Created:
5 years, 10 months ago by jungshik at Google
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix en_GB's language name failure data/lang/en_GB.txt has an empty "Languages" block leading getDisplay{Name,Language} to fail in en-GB. Update trim_data.sh to remove an empty "Languages" block and run the script to fix data/lang/en_GB.txt and other locales if any. (only en_GB.txt is affected). Rebuild the icu data with the above changes for both Android and non-Android platforms. BUG=428145 TEST=linux_chromeos bots: browser_tests --gtest_filter=*GetUILang* TBR=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/8d46830a11d9d1ee7815dbf217c840e74afb8e7e

Patch Set 1 #

Patch Set 2 : uncomment function calls in trim_data.sh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M android/icudtl.dat View Binary file 0 comments Download
M scripts/trim_data.sh View 1 1 chunk +10 lines, -0 lines 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
M source/data/lang/en_GB.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jungshik at Google
PTAL, thanks. This should be the last CL before actually rolling DEPS to 54.1.
5 years, 10 months ago (2015-02-19 18:09:39 UTC) #1
Mark
On 2015/02/19 18:09:39, Jungshik at google wrote: > PTAL, thanks. > > This should be ...
5 years, 10 months ago (2015-02-19 18:11:46 UTC) #3
jungshik at Google
Sending to the correct recipient. :-)
5 years, 10 months ago (2015-02-19 18:35:33 UTC) #5
jungshik at Google
Committed patchset #2 (id:10001) manually as 8d46830a11d9d1ee7815dbf217c840e74afb8e7e (presubmit successful).
5 years, 10 months ago (2015-02-19 19:23:25 UTC) #6
Michael Achenbach
V8 doesn't compile anymore with clang after this change: https://codereview.chromium.org/945703002/ Is there anything wrong on ...
5 years, 10 months ago (2015-02-20 13:21:38 UTC) #8
Michael Achenbach
Looks like the incremental build gets stuck only. It works on a clobbered build. I'll ...
5 years, 10 months ago (2015-02-20 13:35:21 UTC) #9
jungshik at Google
On 2015/02/20 13:35:21, Michael Achenbach wrote: > Looks like the incremental build gets stuck only. ...
5 years, 10 months ago (2015-02-20 17:57:16 UTC) #10
Mark Mentovai
5 years, 10 months ago (2015-02-20 18:00:24 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698