Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 930173002: gl_bindings_skia_in_process is missing GenerateMipmap (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
CC:
bsalomon_chromium, chromium-reviews, Stephen White
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl_bindings_skia_in_process is missing GenerateMipmap Without GenerateMipmap, the gl_bindings_skia_in_process don't work because Skia fails to intialize the GrContext. With this change, the GrContext intializes and works properly. I found this issue when trying to use this code on Android as a backend for Ganesh. R=kbr@chromium.org Committed: https://crrev.com/2887002d5e1f0dee4580cdd69a18a06ba64afff6 Cr-Commit-Position: refs/heads/master@{#316591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/gl/gl_bindings_skia_in_process.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-17 06:47:23 UTC) #1
abarth-chromium
5 years, 10 months ago (2015-02-17 06:48:08 UTC) #2
Ken Russell (switch to Gerrit)
LGTM Could you link to a bug describing why this was just found? How about ...
5 years, 10 months ago (2015-02-17 08:59:34 UTC) #3
abarth-chromium
On 2015/02/17 at 08:59:34, kbr wrote: > Could you link to a bug describing why ...
5 years, 10 months ago (2015-02-17 16:13:22 UTC) #4
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-17 16:13:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930173002/1
5 years, 10 months ago (2015-02-17 16:14:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 17:04:05 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 17:04:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2887002d5e1f0dee4580cdd69a18a06ba64afff6
Cr-Commit-Position: refs/heads/master@{#316591}

Powered by Google App Engine
This is Rietveld 408576698