Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: dart/pkg/compiler/lib/src/resolution/members.dart

Issue 930143002: Remove implicit dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Issues found with unit tests. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/compiler/lib/src/resolution/members.dart
diff --git a/dart/pkg/compiler/lib/src/resolution/members.dart b/dart/pkg/compiler/lib/src/resolution/members.dart
index c1d7ff4b5f14c8ea72f09ed0378400029f7b81a5..c55f1f542031074f65a80094f2d1bf4aac41415f 100644
--- a/dart/pkg/compiler/lib/src/resolution/members.dart
+++ b/dart/pkg/compiler/lib/src/resolution/members.dart
@@ -945,9 +945,17 @@ class ResolverTask extends CompilerTask {
void _postProcessClassElement(BaseClassElementX element) {
for (MetadataAnnotation metadata in element.metadata) {
metadata.ensureResolved(compiler);
- if (!element.isProxy &&
- metadata.constant.value == compiler.proxyConstant) {
- element.isProxy = true;
+ if (!element.isProxy) {
+ ConstantExpression constantExpression = metadata.constant;
+ if (constantExpression != null) {
+ ConstantValue constant = constantExpression.value;
+ if (constant.isConstructedObject) {
+ ObjectConstantValue object = constant;
+ if (object.type.element == compiler.proxyClass) {
+ element.isProxy = true;
+ }
+ }
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698