Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: dart/pkg/compiler/lib/src/js_backend/backend.dart

Issue 930143002: Remove implicit dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Issues found with unit tests. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/dart/pkg/compiler/lib/src/js_backend/backend.dart b/dart/pkg/compiler/lib/src/js_backend/backend.dart
index 90ebafe724f64a76140659e1f701b2492f798b95..72570a44fad7138f2e2527570b65b866f8894959 100644
--- a/dart/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/dart/pkg/compiler/lib/src/js_backend/backend.dart
@@ -949,6 +949,12 @@ class JavaScriptBackend extends Backend {
assert(traceHelper != null);
enqueueInResolution(traceHelper, registry);
}
+
+ // TODO(ahe): Don't know who uses this class, but it wasn't correctly
+ // enqueued after we stopped compiling the @proxy constant eagerly.
+ world.registerInstantiatedClass(
+ interceptorsLibrary.findLocal('JSUInt31'), registry);
ahe 2015/02/18 16:30:56 I have an hypothesis: the ++ and -- operators.
+
registerCheckedModeHelpers(registry);
}
@@ -2384,6 +2390,12 @@ class JavaScriptBackend extends Backend {
}
void registerMainHasArguments(Enqueuer enqueuer) {
+ // The first argument could be a list of strings.
+ enqueuer.registerInstantiatedClass(
+ listImplementation, compiler.globalDependencies);
+ enqueuer.registerInstantiatedClass(
+ stringImplementation, compiler.globalDependencies);
+
// If the main method takes arguments, this compilation could be the target
// of Isolate.spawnUri. Strictly speaking, that can happen also if main
// takes no arguments, but in this case the spawned isolate can't
« no previous file with comments | « dart/pkg/compiler/lib/src/dart_backend/backend.dart ('k') | dart/pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698