Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 930113002: DevTools: Fix debugger command order (Closed)

Created:
5 years, 10 months ago by sergeyv
Modified:
5 years, 10 months ago
Reviewers:
yurys
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vsevik, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix debugger command order Blink-side patch: https://codereview.chromium.org/932523003/ BUG=458035 Committed: https://crrev.com/1bcd626c62e1f19bd11b55ab11190cdff5e18299 Cr-Commit-Position: refs/heads/master@{#316626}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Total comments: 1

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M content/renderer/devtools/devtools_agent_filter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent_filter.cc View 1 2 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
sergeyv
5 years, 10 months ago (2015-02-16 15:52:20 UTC) #2
yurys
https://codereview.chromium.org/930113002/diff/1/content/renderer/devtools/devtools_agent.cc File content/renderer/devtools/devtools_agent.cc (right): https://codereview.chromium.org/930113002/diff/1/content/renderer/devtools/devtools_agent.cc#newcode285 content/renderer/devtools/devtools_agent.cc:285: return; revert this? https://codereview.chromium.org/930113002/diff/1/content/renderer/devtools/devtools_agent_filter.cc File content/renderer/devtools/devtools_agent_filter.cc (right): https://codereview.chromium.org/930113002/diff/1/content/renderer/devtools/devtools_agent_filter.cc#newcode71 content/renderer/devtools/devtools_agent_filter.cc:71: ...
5 years, 10 months ago (2015-02-16 16:30:27 UTC) #3
sergeyv
https://codereview.chromium.org/930113002/diff/1/content/renderer/devtools/devtools_agent.cc File content/renderer/devtools/devtools_agent.cc (right): https://codereview.chromium.org/930113002/diff/1/content/renderer/devtools/devtools_agent.cc#newcode285 content/renderer/devtools/devtools_agent.cc:285: return; On 2015/02/16 16:30:27, yurys wrote: > revert this? ...
5 years, 10 months ago (2015-02-16 17:41:52 UTC) #4
yurys
https://codereview.chromium.org/930113002/diff/20001/content/renderer/devtools/devtools_agent_filter.cc File content/renderer/devtools/devtools_agent_filter.cc (left): https://codereview.chromium.org/930113002/diff/20001/content/renderer/devtools/devtools_agent_filter.cc#oldcode44 content/renderer/devtools/devtools_agent_filter.cc:44: : message_handled_(false), The declaration should also be removed from ...
5 years, 10 months ago (2015-02-16 18:49:44 UTC) #5
sergeyv
On 2015/02/16 18:49:44, yurys wrote: > https://codereview.chromium.org/930113002/diff/20001/content/renderer/devtools/devtools_agent_filter.cc > File content/renderer/devtools/devtools_agent_filter.cc (left): > > https://codereview.chromium.org/930113002/diff/20001/content/renderer/devtools/devtools_agent_filter.cc#oldcode44 > ...
5 years, 10 months ago (2015-02-17 11:23:28 UTC) #6
yurys
lgtm
5 years, 10 months ago (2015-02-17 12:00:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930113002/40001
5 years, 10 months ago (2015-02-17 17:36:09 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-17 19:37:37 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 19:38:36 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1bcd626c62e1f19bd11b55ab11190cdff5e18299
Cr-Commit-Position: refs/heads/master@{#316626}

Powered by Google App Engine
This is Rietveld 408576698