Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 930063002: Revert of scheduler: Implement task observers (Closed)

Created:
5 years, 10 months ago by Sami
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of scheduler: Implement task observers (patchset #7 id:120001 of https://codereview.chromium.org/922733002/) Reason for revert: Broke a CrOS test: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/37585/steps/browser_tests/logs/stdio Original issue's description: > scheduler: Implement task observers > > This patch adds a way for scheduler clients to get notified of task > execution, much like with base::MessageLoop. This is needed to allow > the execution of microtask checkpoints[1] between tasks by Blink while > letting the scheduler use a >1 work batch size. > > This patch also refactors the various WebThreadImpls to reduce code > duplication removes the deprecated postTask entrypoints that don't take > the posting location as a parameter. > > BUG=450977, 444764 > > [1] https://html.spec.whatwg.org/multipage/webappapis.html#processing-model-9 > > Committed: https://crrev.com/ab211a0e344b431ca58c74f7815b15b28f7fb01a > Cr-Commit-Position: refs/heads/master@{#316450} TBR=alexclarke@chromium.org,rmcilroy@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450977, 444764 Committed: https://crrev.com/009f2cf40420e56e8259a6328ef3c265ff59ea27 Cr-Commit-Position: refs/heads/master@{#316479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -359 lines) Patch
M content/child/threaded_data_provider.cc View 5 chunks +13 lines, -16 lines 0 comments Download
M content/child/webthread_impl.h View 3 chunks +32 lines, -41 lines 0 comments Download
M content/child/webthread_impl.cc View 5 chunks +85 lines, -62 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/scheduler/null_renderer_scheduler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/scheduler/null_renderer_scheduler.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.h View 3 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager_unittest.cc View 2 chunks +0 lines, -69 lines 0 comments Download
D content/renderer/scheduler/webthread_impl_for_scheduler.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/renderer/scheduler/webthread_impl_for_scheduler.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M content/test/fake_renderer_scheduler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/fake_renderer_scheduler.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sami
Created Revert of scheduler: Implement task observers
5 years, 10 months ago (2015-02-16 14:41:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930063002/1
5 years, 10 months ago (2015-02-16 14:42:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 14:42:47 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 14:43:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/009f2cf40420e56e8259a6328ef3c265ff59ea27
Cr-Commit-Position: refs/heads/master@{#316479}

Powered by Google App Engine
This is Rietveld 408576698