[turbofan] Transfer types from loop phis to OSR values.

[turbofan] Transfer types from loop phis to OSR values.

R=jarin@chromium.org
BUG=

Committed: https://crrev.com/8e241468ed8183fc4270fd185dde45bafdc9c6f9
Cr-Commit-Position: refs/heads/master@{#26746}

[Jarin, 2015-02-16 14:33:03]

https://codereview.chromium.org/930003003/diff/1/src/compiler/osr.cc
File src/compiler/osr.cc (right):

https://codereview.chromium.org/930003003/diff/1/src/compiler/osr.cc#newcode195
src/compiler/osr.cc:195: NodeProperties::SetBounds(osr_value,
NodeProperties::GetBounds(phi));
As discussed offline, we should combine the types of all phis rather than using
just one phi to type the osr value.

[titzer, 2015-02-16 15:42:54]

On 2015/02/16 14:33:03, jarin wrote:
> https://codereview.chromium.org/930003003/diff/1/src/compiler/osr.cc
> File src/compiler/osr.cc (right):
> 
>
https://codereview.chromium.org/930003003/diff/1/src/compiler/osr.cc#newcode195
> src/compiler/osr.cc:195: NodeProperties::SetBounds(osr_value,
> NodeProperties::GetBounds(phi));
> As discussed offline, we should combine the types of all phis rather than
using
> just one phi to type the osr value.

Done.

[titzer, 2015-02-18 09:03:46]

On 2015/02/16 15:42:54, titzer wrote:
> On 2015/02/16 14:33:03, jarin wrote:
> > https://codereview.chromium.org/930003003/diff/1/src/compiler/osr.cc
> > File src/compiler/osr.cc (right):
> > 
> >
>
https://codereview.chromium.org/930003003/diff/1/src/compiler/osr.cc#newcode195
> > src/compiler/osr.cc:195: NodeProperties::SetBounds(osr_value,
> > NodeProperties::GetBounds(phi));
> > As discussed offline, we should combine the types of all phis rather than
> using
> > just one phi to type the osr value.
> 
> Done.

PTAL

[titzer, 2015-02-18 09:04:49]

titzer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-02-18 09:18:10]

LGTM with comment.

https://codereview.chromium.org/930003003/diff/40001/src/compiler/osr.cc
File src/compiler/osr.cc (right):

https://codereview.chromium.org/930003003/diff/40001/src/compiler/osr.cc#newc...
src/compiler/osr.cc:206: if (unknown) NodeProperties::SetBounds(osr_value,
Bounds::Unbounded(zone));
I'd suggest to use

 NodeProperties::SetBounds(osr_value, Bounds::Unbounded(zone));

as default before the loop instead of having that unknown variable. Then you
don't need the !NodeProperties::IsTyped(osr_value) case above, but you can
always intersect the osr_value bounds.

[titzer, 2015-02-19 11:21:16]

On 2015/02/18 09:18:10, Benedikt Meurer wrote:
> LGTM with comment.
> 
> https://codereview.chromium.org/930003003/diff/40001/src/compiler/osr.cc
> File src/compiler/osr.cc (right):
> 
>
https://codereview.chromium.org/930003003/diff/40001/src/compiler/osr.cc#newc...
> src/compiler/osr.cc:206: if (unknown) NodeProperties::SetBounds(osr_value,
> Bounds::Unbounded(zone));
> I'd suggest to use
> 
>  NodeProperties::SetBounds(osr_value, Bounds::Unbounded(zone));
> 
> as default before the loop instead of having that unknown variable. Then you
> don't need the !NodeProperties::IsTyped(osr_value) case above, but you can
> always intersect the osr_value bounds.

Done. (using unknown flag in loop).

[titzer, 2015-02-19 11:21:50]

New patchsets have been uploaded after l-g-t-m from bmeurer@chromium.org

[titzer, 2015-02-19 12:17:13]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2015-02-19 12:17:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/930003003/80001

[commit-bot: I haz the power, 2015-02-19 12:38:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-19 12:39:01]

Patchset 5 (id:??) landed as
https://crrev.com/8e241468ed8183fc4270fd185dde45bafdc9c6f9
Cr-Commit-Position: refs/heads/master@{#26746}