Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 929973002: Revert "Fix JSArrayBufferView visitor template to fix ARM build." (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Fix JSArrayBufferView visitor template to fix ARM build." and "Just visit young array buffers during scavenge. Additionally keep the views in new space in a separate global list and move them to the corresponding array buffers when they get promoted." This reverts commit 295ab2783025237dd7a1c86ddb13690d910622a1 and commit bd61a85fafd6461a40dc1e20252fd843f148e837. TBR=hpayer@chromium.org NOTRY=true Committed: https://crrev.com/e66d39a6be459381e68d07d013170d45d57a706c Cr-Commit-Position: refs/heads/master@{#26653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -235 lines) Patch
M src/factory.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/heap/heap.h View 5 chunks +2 lines, -25 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +9 lines, -70 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/objects-visiting.cc View 5 chunks +15 lines, -28 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 5 chunks +6 lines, -46 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 6 chunks +17 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
5 years, 10 months ago (2015-02-16 08:55:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929973002/1
5 years, 10 months ago (2015-02-16 08:56:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929973002/1
5 years, 10 months ago (2015-02-16 09:20:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 09:20:49 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 09:21:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e66d39a6be459381e68d07d013170d45d57a706c
Cr-Commit-Position: refs/heads/master@{#26653}

Powered by Google App Engine
This is Rietveld 408576698