Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp - Issue 929953002: CachedMetadata support for ServiceWorker script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 929953002: CachedMetadata support for ServiceWorker script. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated tkent's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

index bb99c5e6a914328424a83be73324e120dd5bb0f6..2046bac1db444fdc8dd25bb6eb282bedee6b0beb 100644

--- a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

@@ -388,7 +388,7 @@ void V8InjectedScriptHost::evaluateWithExceptionDetailsMethodCustom(const v8::Fu

ASSERT(isolate->InContext());

v8::TryCatch tryCatch;

- v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(expression, String(), TextPosition(), 0, 0, isolate);

+ v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(expression, String(), TextPosition(), isolate);

v8::Handle<v8::Value> result = V8ScriptRunner::runCompiledScript(isolate, script, currentExecutionContext(isolate));

v8::Local<v8::Object> wrappedResult = v8::Object::New(isolate);

« no previous file with comments | « Source/bindings/core/v8/WorkerScriptController.cpp ('k') | Source/core/core.gypi » ('j') | no next file with comments »