Remove cc dependency from ui/base

Remove cc dependency from ui/base

This CL is a follow-up to https://codereview.chromium.org/908033003/  to remove cc dependency from ui/base on android platform.

BUG=458889
Committed: https://crrev.com/e4f9eed47cafe53d279d9aa0529283f978950581
Cr-Commit-Position: refs/heads/master@{#317737}

[Jaekyun Seok (inactive), 2015-02-16 14:00:12]

jaekyun@chromium.org changed reviewers:
+ aelias@chromium.org, dtrainor@chromium.org, jdduke@chromium.org,
spang@chromium.org

[Jaekyun Seok (inactive), 2015-02-16 14:00:13]

Please review this CL.

[jdduke (slow), 2015-02-17 16:59:43]

On 2015/02/16 14:00:13, Jaekyun Seok (OOOuntilFeb23) wrote:
> Please review this CL.

For future reference, particularly with large CLs that have many reviewers,
please outline exactly which files you want reviewed by each reviewer. Often
there is overlap between ownership, and it saves everybody time.

[aelias_OOO_until_Jul13, 2015-02-17 21:43:07]

content/browser/renderer_host/ lgtm

[spang, 2015-02-17 23:09:48]

On 2015/02/16 14:00:13, Jaekyun Seok (OOOuntilFeb23) wrote:
> Please review this CL.

Thanks for this.

I landed the previous patch. When you rebase just delete ui/base/android/DEPS.

[David Trainor- moved to gerrit, 2015-02-19 00:52:28]

chrome/android lgtm (and anything else where I'm an owner...).  Thanks!

[Jaekyun Seok (inactive), 2015-02-23 04:09:46]

On 2015/02/17 16:59:43, jdduke wrote:
> On 2015/02/16 14:00:13, Jaekyun Seok (OOOuntilFeb23) wrote:
> > Please review this CL.
> 
> For future reference, particularly with large CLs that have many reviewers,
> please outline exactly which files you want reviewed by each reviewer. Often
> there is overlap between ownership, and it saves everybody time.

Sorry for my poor comments on the review request.

jdduke@, I want you to review changes on content/*, ui/base/* and ui/android/*.

[Jaekyun Seok (inactive), 2015-02-23 04:21:33]

jaekyun@chromium.org changed reviewers:
+ blundell@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 04:21:34]

blundell@chromium.org: Please review changes in components/*.

[Jaekyun Seok (inactive), 2015-02-23 04:22:15]

jaekyun@chromium.org changed reviewers:
+ sievers@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 04:22:16]

sievers@chromium.org: Please review changes in content/*.

[Jaekyun Seok (inactive), 2015-02-23 04:23:04]

jaekyun@chromium.org changed reviewers:
+ jhawkins@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 04:23:05]

jhawkins@chromium.org: Please review changes in chrome/*.

[Jaekyun Seok (inactive), 2015-02-23 04:25:24]

jaekyun@chromium.org changed reviewers:
+ sadrul@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 04:25:24]

sadrul@chromium.org: Please review changes in ui/*.

[Jaekyun Seok (inactive), 2015-02-23 05:12:34]

New patchsets have been uploaded after l-g-t-m from
aelias@chromium.org,dtrainor@chromium.org

[blundell, 2015-02-23 08:43:13]

An OWNER of the component in question would be a better reviewer here.

[Jaekyun Seok (inactive), 2015-02-23 09:01:04]

On 2015/02/23 08:43:13, blundell wrote:
> An OWNER of the component in question would be a better reviewer here.

I see. I will add aurimas@ as a reviewer for
ui/shell_dialogs/select_file_dialog_android.cc.

But, blundell@, could you please review ui/**/DEPS, ui/**/BUILD.gn, and
ui/**/*.gyp because there isn't any specific owner for those files in each
component?

[Jaekyun Seok (inactive), 2015-02-23 09:02:45]

jaekyun@chromium.org changed reviewers:
+ aurimas@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 09:02:46]

aurimas@, please review changes in
ui/shell_dialogs/select_file_dialog_android.cc .

[blundell, 2015-02-23 09:09:14]

On 2015/02/23 09:01:04, Jaekyun Seok (OOOuntilFeb23) wrote:
> On 2015/02/23 08:43:13, blundell wrote:
> > An OWNER of the component in question would be a better reviewer here.
> 
> I see. I will add aurimas@ as a reviewer for
> ui/shell_dialogs/select_file_dialog_android.cc.
> 
> But, blundell@, could you please review ui/**/DEPS, ui/**/BUILD.gn, and
> ui/**/*.gyp because there isn't any specific owner for those files in each
> component?

I was added as a //components OWNER; that's what I'm referring to. I'm not a
//ui OWNER ;).

[Jaekyun Seok (inactive), 2015-02-23 09:50:54]

On 2015/02/23 09:09:14, blundell wrote:
> On 2015/02/23 09:01:04, Jaekyun Seok (OOOuntilFeb23) wrote:
> > On 2015/02/23 08:43:13, blundell wrote:
> > > An OWNER of the component in question would be a better reviewer here.
> > 
> > I see. I will add aurimas@ as a reviewer for
> > ui/shell_dialogs/select_file_dialog_android.cc.
> > 
> > But, blundell@, could you please review ui/**/DEPS, ui/**/BUILD.gn, and
> > ui/**/*.gyp because there isn't any specific owner for those files in each
> > component?
> 
> I was added as a //components OWNER; that's what I'm referring to. I'm not a
> //ui OWNER ;).

Sorry, I was confused. Please review
components/web_contents_delegate_android.gypi instead.

[Jaekyun Seok (inactive), 2015-02-23 09:52:13]

jaekyun@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 09:52:14]

tedchoc@, please review changes in components/web_contents_delegate_android/*.

[blundell, 2015-02-23 09:53:16]

//components/*.gypi LGTM

[jdduke (slow), 2015-02-23 16:02:55]

On 2015/02/23 04:09:46, Jaekyun Seok (OOOuntilFeb23) wrote:
> Sorry for my poor comments on the review request.

No worries!

> jdduke@, I want you to review changes on content/*, ui/base/* and
ui/android/*.

content/browser/android, ui/base/android and ui/android lgtm.

[aurimas (slooooooooow), 2015-02-23 17:57:58]

ui/shell_dialogs/select_file_dialog_android.cc LTGM

[Ted C, 2015-02-23 18:11:25]

components/web_contents_delegate_android/ - lgtm

[James Hawkins, 2015-02-23 18:16:25]

Please list the specific files you're asking me to review.

[no sievers, 2015-02-23 19:20:34]

content/ lgtm

[spang, 2015-02-23 19:22:44]

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
File ui/android/DEPS (right):

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
ui/android/DEPS:2: "+cc/output/copy_output_request.h",
You should be able to delete ui/base/android/DEPS now right?

[Jaekyun Seok (inactive), 2015-02-23 20:27:48]

On 2015/02/23 18:16:25, James Hawkins wrote:
> Please list the specific files you're asking me to review.

jhawkins@, please review changes in chrome/browser/platform_util_android.cc and
chrome/browser/supervised_user/child_accounts/child_account_feedback_reporter_android.cc.

[Jaekyun Seok (inactive), 2015-02-23 20:29:25]

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
File ui/android/DEPS (right):

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
ui/android/DEPS:2: "+cc/output/copy_output_request.h",
On 2015/02/23 19:22:44, spang wrote:
> You should be able to delete ui/base/android/DEPS now right?

I've already removed the previous changes in ui/base/android/DEPS.

[Jaekyun Seok (inactive), 2015-02-23 20:30:44]

On 2015/02/23 04:25:24, Jaekyun Seok (OOOuntilFeb23) wrote:
> mailto:sadrul@chromium.org: Please review changes in ui/*.

sadrul@, please review ui/**/DEPS, ui/**/BUILD.gn, and ui/**/*.gyp.

[spang, 2015-02-23 20:36:14]

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
File ui/android/DEPS (right):

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
ui/android/DEPS:2: "+cc/output/copy_output_request.h",
On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote:
> On 2015/02/23 19:22:44, spang wrote:
> > You should be able to delete ui/base/android/DEPS now right?
> 
> I've already removed the previous changes in ui/base/android/DEPS.

I'm not seeing any removal in the patch or in the tree.

[Jaekyun Seok (inactive), 2015-02-23 20:44:08]

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
File ui/android/DEPS (right):

https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
ui/android/DEPS:2: "+cc/output/copy_output_request.h",
On 2015/02/23 20:36:14, spang wrote:
> On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote:
> > On 2015/02/23 19:22:44, spang wrote:
> > > You should be able to delete ui/base/android/DEPS now right?
> > 
> > I've already removed the previous changes in ui/base/android/DEPS.
> 
> I'm not seeing any removal in the patch or in the tree.

This file is ui/android/DEPS, not ui/base/android/DEPS.

You can see changes in ui/base/DEPS of patch set #4 gone in the latest patch
set.

[spang, 2015-02-23 20:47:59]

On 2015/02/23 20:44:08, Jaekyun Seok (OOOuntilFeb23) wrote:
> https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
> File ui/android/DEPS (right):
> 
>
https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
> ui/android/DEPS:2: "+cc/output/copy_output_request.h",
> On 2015/02/23 20:36:14, spang wrote:
> > On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote:
> > > On 2015/02/23 19:22:44, spang wrote:
> > > > You should be able to delete ui/base/android/DEPS now right?
> > > 
> > > I've already removed the previous changes in ui/base/android/DEPS.
> > 
> > I'm not seeing any removal in the patch or in the tree.
> 
> This file is ui/android/DEPS, not ui/base/android/DEPS.
> 
> You can see changes in ui/base/DEPS of patch set #4 gone in the latest patch
> set.

Please look again. The file is now ui/base/android/DEPS.

https://chromium.googlesource.com/chromium/src/+/master/ui/base/android/DEPS

[Jaekyun Seok (inactive), 2015-02-23 21:10:26]

On 2015/02/23 20:47:59, spang wrote:
> On 2015/02/23 20:44:08, Jaekyun Seok (OOOuntilFeb23) wrote:
> > https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
> > File ui/android/DEPS (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
> > ui/android/DEPS:2: "+cc/output/copy_output_request.h",
> > On 2015/02/23 20:36:14, spang wrote:
> > > On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote:
> > > > On 2015/02/23 19:22:44, spang wrote:
> > > > > You should be able to delete ui/base/android/DEPS now right?
> > > > 
> > > > I've already removed the previous changes in ui/base/android/DEPS.
> > > 
> > > I'm not seeing any removal in the patch or in the tree.
> > 
> > This file is ui/android/DEPS, not ui/base/android/DEPS.
> > 
> > You can see changes in ui/base/DEPS of patch set #4 gone in the latest patch
> > set.
> 
> Please look again. The file is now ui/base/android/DEPS.
> 
> https://chromium.googlesource.com/chromium/src/+/master/ui/base/android/DEPS

I understood now. I thought you were saying ui/base/DEPS. I will remove
ui/base/android/DEPS.

[Jaekyun Seok (inactive), 2015-02-23 21:21:04]

On 2015/02/23 21:10:26, Jaekyun Seok (OOOuntilFeb23) wrote:
> On 2015/02/23 20:47:59, spang wrote:
> > On 2015/02/23 20:44:08, Jaekyun Seok (OOOuntilFeb23) wrote:
> > >
https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
> > > File ui/android/DEPS (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
> > > ui/android/DEPS:2: "+cc/output/copy_output_request.h",
> > > On 2015/02/23 20:36:14, spang wrote:
> > > > On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote:
> > > > > On 2015/02/23 19:22:44, spang wrote:
> > > > > > You should be able to delete ui/base/android/DEPS now right?
> > > > > 
> > > > > I've already removed the previous changes in ui/base/android/DEPS.
> > > > 
> > > > I'm not seeing any removal in the patch or in the tree.
> > > 
> > > This file is ui/android/DEPS, not ui/base/android/DEPS.
> > > 
> > > You can see changes in ui/base/DEPS of patch set #4 gone in the latest
patch
> > > set.
> > 
> > Please look again. The file is now ui/base/android/DEPS.
> > 
> > https://chromium.googlesource.com/chromium/src/+/master/ui/base/android/DEPS
> 
> I understood now. I thought you were saying ui/base/DEPS. I will remove
> ui/base/android/DEPS.

I removed the file in the latest patch set.

[spang, 2015-02-23 21:23:45]

On 2015/02/23 21:21:04, Jaekyun Seok (OOOuntilFeb23) wrote:
> On 2015/02/23 21:10:26, Jaekyun Seok (OOOuntilFeb23) wrote:
> > On 2015/02/23 20:47:59, spang wrote:
> > > On 2015/02/23 20:44:08, Jaekyun Seok (OOOuntilFeb23) wrote:
> > > >
> https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS
> > > > File ui/android/DEPS (right):
> > > > 
> > > >
> > >
> >
>
https://chromiumcodereview.appspot.com/929903002/diff/80001/ui/android/DEPS#n...
> > > > ui/android/DEPS:2: "+cc/output/copy_output_request.h",
> > > > On 2015/02/23 20:36:14, spang wrote:
> > > > > On 2015/02/23 20:29:24, Jaekyun Seok (OOOuntilFeb23) wrote:
> > > > > > On 2015/02/23 19:22:44, spang wrote:
> > > > > > > You should be able to delete ui/base/android/DEPS now right?
> > > > > > 
> > > > > > I've already removed the previous changes in ui/base/android/DEPS.
> > > > > 
> > > > > I'm not seeing any removal in the patch or in the tree.
> > > > 
> > > > This file is ui/android/DEPS, not ui/base/android/DEPS.
> > > > 
> > > > You can see changes in ui/base/DEPS of patch set #4 gone in the latest
> patch
> > > > set.
> > > 
> > > Please look again. The file is now ui/base/android/DEPS.
> > > 
> > >
https://chromium.googlesource.com/chromium/src/+/master/ui/base/android/DEPS
> > 
> > I understood now. I thought you were saying ui/base/DEPS. I will remove
> > ui/base/android/DEPS.
> 
> I removed the file in the latest patch set.

lgtm & thanks again for taking this on

[sadrul, 2015-02-23 21:26:55]

lgtm

[James Hawkins, 2015-02-23 22:16:39]

lgtm

[Jaekyun Seok (inactive), 2015-02-23 22:39:10]

The CQ bit was checked by jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 22:39:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jdduke@chromium.org,
dtrainor@chromium.org, aelias@chromium.org, tedchoc@chromium.org,
sievers@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/929903002/#ps100001
(title: "Remove ui/base/android/DEPS")

[commit-bot: I haz the power, 2015-02-23 22:41:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/929903002/100001

[commit-bot: I haz the power, 2015-02-23 23:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:27:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jaekyun Seok (inactive), 2015-02-23 23:52:18]

jaekyun@chromium.org changed reviewers:
+ tfarina@chromium.org

[Jaekyun Seok (inactive), 2015-02-23 23:52:19]

tfarina@, could you please take a look at chromium_presubmit failure of
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...
.

This seems related to your change of https://codereview.chromium.org/893923002 .

Please let me know how to fix this failure.

[Jaekyun Seok (inactive), 2015-02-24 00:16:28]

On 2015/02/23 23:52:19, Jaekyun Seok (OOOuntilFeb23) wrote:
> tfarina@, could you please take a look at chromium_presubmit failure of
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...
> .
> 
> This seems related to your change of https://codereview.chromium.org/893923002
.
> 
> Please let me know how to fix this failure.

tfarina@, could you please review changes in ui/PRESUBMIT.py?

I modified it to fix chromium_presubmit failure of
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...
.

I just copied the logic from chrome/PRESUBMIT.py .

[tfarina, 2015-02-24 00:17:55]

On Monday, February 23, 2015, <jaekyun@chromium.org> wrote:

> On 2015/02/23 23:52:19, Jaekyun Seok (OOOuntilFeb23) wrote:
>
>> tfarina@, could you please take a look at chromium_presubmit failure of
>>
>
> http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/44836
>
>> .
>>
>
>  This seems related to your change of https://codereview.chromium.
>> org/893923002
>>
> .
>
>  Please let me know how to fix this failure.
>>
>
> tfarina@, could you please review changes in ui/PRESUBMIT.py?
>
> Yep. I will fix it. Looking...


> I modified it to fix chromium_presubmit failure of
> http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/44836
> .
>
> I just copied the logic from chrome/PRESUBMIT.py .
>
> https://codereview.chromium.org/929903002/
>


-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jaekyun Seok (inactive), 2015-02-24 00:19:35]

FYI, the errors on chromium_presubmit were like the followings.

Traceback (most recent call last):
  File "/b/depot_tools/presubmit_support.py", line 1678, in <module>
    sys.exit(Main(None))
  File "/b/depot_tools/presubmit_support.py", line 1663, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1396, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1313, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 56, in CheckChangeOnCommit
  File "<string>", line 47, in CheckChange
  File "<string>", line 38, in CheckScopedPtr
NameError: global name 're' is not defined

[tfarina, 2015-02-24 00:24:11]

Yep.  OK. Scott already reverted it!

On Mon, Feb 23, 2015 at 9:19 PM, <jaekyun@chromium.org> wrote:

> FYI, the errors on chromium_presubmit were like the followings.
>
> Traceback (most recent call last):
>   File "/b/depot_tools/presubmit_support.py", line 1678, in <module>
>     sys.exit(Main(None))
>   File "/b/depot_tools/presubmit_support.py", line 1663, in Main
>     rietveld_obj)
>   File "/b/depot_tools/presubmit_support.py", line 1396, in
> DoPresubmitChecks
>     results += executer.ExecPresubmitScript(presubmit_script, filename)
>   File "/b/depot_tools/presubmit_support.py", line 1313, in
> ExecPresubmitScript
>     result = eval(function_name + '(*__args)', context)
>   File "<string>", line 1, in <module>
>   File "<string>", line 56, in CheckChangeOnCommit
>   File "<string>", line 47, in CheckChange
>   File "<string>", line 38, in CheckScopedPtr
> NameError: global name 're' is not defined
>
>
> https://codereview.chromium.org/929903002/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jaekyun Seok (inactive), 2015-02-24 00:44:58]

On 2015/02/24 00:24:11, tfarina wrote:
> Yep.  OK. Scott already reverted it!

I see. Then I will wait for the reverted CL.

> 
> On Mon, Feb 23, 2015 at 9:19 PM, <mailto:jaekyun@chromium.org> wrote:
> 
> > FYI, the errors on chromium_presubmit were like the followings.
> >
> > Traceback (most recent call last):
> >   File "/b/depot_tools/presubmit_support.py", line 1678, in <module>
> >     sys.exit(Main(None))
> >   File "/b/depot_tools/presubmit_support.py", line 1663, in Main
> >     rietveld_obj)
> >   File "/b/depot_tools/presubmit_support.py", line 1396, in
> > DoPresubmitChecks
> >     results += executer.ExecPresubmitScript(presubmit_script, filename)
> >   File "/b/depot_tools/presubmit_support.py", line 1313, in
> > ExecPresubmitScript
> >     result = eval(function_name + '(*__args)', context)
> >   File "<string>", line 1, in <module>
> >   File "<string>", line 56, in CheckChangeOnCommit
> >   File "<string>", line 47, in CheckChange
> >   File "<string>", line 38, in CheckScopedPtr
> > NameError: global name 're' is not defined
> >
> >
> > https://codereview.chromium.org/929903002/
> >
> 
> 
> 
> -- 
> Thiago Farina
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Jaekyun Seok (inactive), 2015-02-24 00:46:03]

FYI, I reverted changes in patch set 7, and so patch set 8 is same to patch set
6.

[Jaekyun Seok (inactive), 2015-02-24 01:02:11]

The CQ bit was checked by jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-02-24 01:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jdduke@chromium.org,
sadrul@chromium.org, dtrainor@chromium.org, aelias@chromium.org,
tedchoc@chromium.org, sievers@chromium.org, blundell@chromium.org,
jhawkins@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/929903002/#ps140001
(title: "Revert changes in ui/PRESUBMIT.py")

[commit-bot: I haz the power, 2015-02-24 01:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/929903002/140001

[commit-bot: I haz the power, 2015-02-24 02:07:25]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-02-24 02:08:05]

Patchset 8 (id:??) landed as
https://crrev.com/e4f9eed47cafe53d279d9aa0529283f978950581
Cr-Commit-Position: refs/heads/master@{#317737}