Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: Source/core/rendering/RenderInline.cpp

Issue 929883003: Resolve flickering the text selection when hitting culled inline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/drag-selects-culled-inlines-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderInline.cpp
diff --git a/Source/core/rendering/RenderInline.cpp b/Source/core/rendering/RenderInline.cpp
index a3d775c8c33027a53b527754dc48cb52357e56e9..2c33e9eb9e1b64a41c4b8cd3e562d7d958b5a38d 100644
--- a/Source/core/rendering/RenderInline.cpp
+++ b/Source/core/rendering/RenderInline.cpp
@@ -835,7 +835,7 @@ PositionWithAffinity RenderInline::positionForPoint(const LayoutPoint& point)
{
// FIXME: Does not deal with relative positioned inlines (should it?)
RenderBlock* cb = containingBlock();
- if (firstLineBox()) {
+ if (firstLineBoxIncludingCulling()) {
// This inline actually has a line box. We must have clicked in the border/padding of one of these boxes. We
// should try to find a result by asking our containing block.
return cb->positionForPoint(point);
« no previous file with comments | « LayoutTests/fast/events/drag-selects-culled-inlines-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698