Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: Source/core/rendering/RenderInline.cpp

Issue 929883003: Resolve flickering the text selection when hitting culled inline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderInline.cpp
diff --git a/Source/core/rendering/RenderInline.cpp b/Source/core/rendering/RenderInline.cpp
index 9956e851279d96343b3233742bd5654fc45590f5..0b2b0f259306dba6f2a4971ae39ecfe1c416bfd2 100644
--- a/Source/core/rendering/RenderInline.cpp
+++ b/Source/core/rendering/RenderInline.cpp
@@ -835,7 +835,7 @@ PositionWithAffinity RenderInline::positionForPoint(const LayoutPoint& point)
{
// FIXME: Does not deal with relative positioned inlines (should it?)
RenderBlock* cb = containingBlock();
- if (firstLineBox()) {
+ if (firstLineBoxIncludingCulling()) {
pdr. 2015/02/16 20:24:09 There are 35 other callers of firstLineBox(). Is t
Miyoung Shin(g) 2015/02/17 05:01:54 We need only this to solve the problem that flicke
// This inline actually has a line box. We must have clicked in the border/padding of one of these boxes. We
// should try to find a result by asking our containing block.
return cb->positionForPoint(point);

Powered by Google App Engine
This is Rietveld 408576698