LayoutTests/fast/events/drag-selects-culled-inlines.html - Issue 929883003: Resolve flickering the text selection when hitting culled inline.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/drag-selects-culled-inlines.html

Issue 929883003: Resolve flickering the text selection when hitting culled inline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .style1 { font-size: 14px; color: #CC3300; }

	4 .text1 { font-size: 11px; color: #7f0000; }

	5 </style>

	6 <div id="test" class="style1" height="106">
	pdr. 2015/02/16 20:24:09 Is this explicit height required? Is this explicit height required? Miyoung Shin(g) 2015/02/17 05:01:54 Done. Show quoted text On 2015/02/16 20:24:09, pdr wrote: > Is this explicit height required? Done.
	7 <font><br>

	8 <span class="text1">Some Text1 <span id="noRange" style="font-weight: 400"> <b>S ome Text2</b></span><br>Some Text3<br></strong>Some Text4<br></span>

	9 </font>

	10 </div>

	11 <div id="description">

	12 </div>

	13 <script src="../../resources/js-test.js"></script>

	14 <script>

	15 jsTestIsAsync = true;

	16 var testDone = false;

	17 description('Test that flickering is observed on text selection when culled inline is selected')

	18

	19 document.onselectionchange = function () {

	20 shouldBeFalse("window.getSelection().containsNode(document.getElementByI d('noRange'))");

	21 if (testDone)

	22 finishJSTest();

	23 }

	24

	25 if (window.testRunner && window.eventSender) {

	26 var element = document.getElementById('test');

	27 eventSender.mouseMoveTo(element.offsetLeft + 10, element.offsetTop + ele ment.offsetHeight - 1);

	28 eventSender.mouseDown();

	29 // move to the position of culled inline.

	30 eventSender.mouseMoveTo(element.offsetLeft + 10, element.offsetHeight - 25);
	pdr. 2015/02/16 20:24:09 offsetHeight - 25 may be flaky on other platforms. offsetHeight - 25 may be flaky on other platforms. I think you're trying to move between two lines? If so, can you make this explicit by moving to: (line1.offsetTop line1.offsetHeight + line2.offsetTop) / 2 Miyoung Shin(g) 2015/02/17 05:01:54 Done.I changed it to use only the offsetTop and of Show quoted text On 2015/02/16 20:24:09, pdr wrote: > offsetHeight - 25 may be flaky on other platforms. I think you're trying to move > between two lines? If so, can you make this explicit by moving to: > (line1.offsetTop line1.offsetHeight + line2.offsetTop) / 2 Done.I changed it to use only the offsetTop and offsetHeight of the last line.
	31 eventSender.mouseUp();

	32 testDone = true;

	33 }

	34 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/drag-selects-culled-inlines-expected.txt » ('j') | Source/core/rendering/RenderInline.cpp » ('J')