Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ui/views/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/BUILD.gn
diff --git a/ui/views/BUILD.gn b/ui/views/BUILD.gn
index fdfe02c04ab9fbfbc0eebafa03538aaa095cade3..e4cbff6807173de409eddf60566dc49d06b3bf8e 100644
--- a/ui/views/BUILD.gn
+++ b/ui/views/BUILD.gn
@@ -14,6 +14,9 @@ gypi_values = exec_script("//build/gypi_to_gn.py",
component("views") {
sources = gypi_values.views_sources
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
defines = [ "VIEWS_IMPLEMENTATION" ]
deps = [
@@ -67,7 +70,6 @@ component("views") {
if (is_win) {
sources += gypi_values.views_win_sources
- cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
libs = [
"imm32.lib",
"oleacc.lib",

Powered by Google App Engine
This is Rietveld 408576698