Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: ui/gfx/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/BUILD.gn
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index b037516ff100d4b544a3600a2acc3be9f8ee1404..6d3bd5c03171b1d9ecd241ba9ebef560cbd93458 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -222,6 +222,9 @@ component("gfx") {
"win/window_impl.h",
]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
defines = [ "GFX_IMPLEMENTATION" ]
deps = [
@@ -305,7 +308,6 @@ component("gfx") {
# Windows.
if (is_win) {
cflags = [
- "/wd4267", # TODO(jschuh): C4267: http://crbug.com/167187 size_t -> int.
"/wd4324", # Structure was padded due to __declspec(align()), which is
# uninteresting.
]
@@ -450,6 +452,9 @@ test("gfx_unittests") {
]
}
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
deps = [
":gfx",
":test_support",
@@ -509,9 +514,6 @@ test("gfx_unittests") {
"imm32.lib",
"oleacc.lib",
]
-
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
}
}

Powered by Google App Engine
This is Rietveld 408576698