Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/libexif/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libexif/BUILD.gn
diff --git a/third_party/libexif/BUILD.gn b/third_party/libexif/BUILD.gn
index b2b4feda061ddf0c1324d91eca62aeadccd18df9..a67566142e2ff3fd5ed9bd9d447233cadb5b3235 100644
--- a/third_party/libexif/BUILD.gn
+++ b/third_party/libexif/BUILD.gn
@@ -53,7 +53,6 @@ if (!is_linux || is_chromeos) {
cflags = [
"/wd4018", # size/unsigned mismatch
- "/wd4267", # size_t -> ExifLong truncation on amd64
]
# TODO(GYP): Handle /analyze switch, when it will be used in GN.
@@ -62,7 +61,11 @@ if (!is_linux || is_chromeos) {
}
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ "//build/config/compiler:no_size_t_to_int_warning",
+ ]
public_configs = [ ":libexif_config" ]
}

Powered by Google App Engine
This is Rietveld 408576698