Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/shell/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/ppapi_plugin/broker_process_dispatcher.cc ('K') | « content/renderer/BUILD.gn ('k') | courgette/BUILD.gn » ('j') | net/third_party/nss/ssl/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index 338c565bb0da06ecdc1b29193f6a251c6f2fa89c..b0f6e1bd6c2289f84a07ad300efafb2c64016512 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -225,6 +225,9 @@ static_library("content_shell_lib") {
"renderer/test_runner/web_test_runner.h",
]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
defines = [ "CONTENT_SHELL_VERSION=\"$content_shell_version\"" ]
public_deps = [
@@ -280,9 +283,6 @@ static_library("content_shell_lib") {
if (is_win) {
#'LinkIncremental': '<(msvs_large_module_debug_link_mode)', TODO(GYP)
-
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
sources += [
"common/v8_breakpad_support_win.cc",
"common/v8_breakpad_support_win.h",
« content/ppapi_plugin/broker_process_dispatcher.cc ('K') | « content/renderer/BUILD.gn ('k') | courgette/BUILD.gn » ('j') | net/third_party/nss/ssl/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698