Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: cc/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/BUILD.gn
diff --git a/cc/BUILD.gn b/cc/BUILD.gn
index dafa89a13f1dce0ebebff797c4b4747584ec74f9..d3bc7619370d5a26006d72d75e43cd3280cf202e 100644
--- a/cc/BUILD.gn
+++ b/cc/BUILD.gn
@@ -536,10 +536,8 @@ component("cc") {
"trees/tree_synchronizer.h",
]
- if (is_win) {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ] # size_t -> int
- }
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
public_deps = [
"//skia",
@@ -697,6 +695,8 @@ source_set("test_support") {
"test/tiled_layer_test_common.h",
]
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
include_dirs = [
".",
"test",

Powered by Google App Engine
This is Rietveld 408576698