Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/snappy/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("snappy_config") { 5 config("snappy_config") {
6 include_dirs = [ "src" ] 6 include_dirs = [ "src" ]
7 7
8 # These OS-specific generated headers were made by running the configure 8 # These OS-specific generated headers were made by running the configure
9 # script offline. 9 # script offline.
10 if (is_win) { 10 if (is_win) {
(...skipping 10 matching lines...) Expand all
21 "src/snappy-internal.h", 21 "src/snappy-internal.h",
22 "src/snappy-sinksource.cc", 22 "src/snappy-sinksource.cc",
23 "src/snappy-sinksource.h", 23 "src/snappy-sinksource.h",
24 "src/snappy-stubs-internal.cc", 24 "src/snappy-stubs-internal.cc",
25 "src/snappy-stubs-internal.h", 25 "src/snappy-stubs-internal.h",
26 "src/snappy.cc", 26 "src/snappy.cc",
27 "src/snappy.h", 27 "src/snappy.h",
28 ] 28 ]
29 29
30 configs -= [ "//build/config/compiler:chromium_code" ] 30 configs -= [ "//build/config/compiler:chromium_code" ]
31 configs += [ "//build/config/compiler:no_chromium_code" ] 31 configs += [
32 "//build/config/compiler:no_chromium_code",
33 # https://code.google.com/p/snappy/issues/detail?id=75
34 "//build/config/compiler:no_size_t_to_int_warning",
35 ]
32 public_configs = [ ":snappy_config" ] 36 public_configs = [ ":snappy_config" ]
33 37
34 if (is_clang) { 38 if (is_clang) {
35 # snappy-stubs-internal.h unapologetically has: using namespace std 39 # snappy-stubs-internal.h unapologetically has: using namespace std
36 # https://code.google.com/p/snappy/issues/detail?id=70 40 # https://code.google.com/p/snappy/issues/detail?id=70
37 configs -= [ "//build/config/clang:extra_warnings" ] 41 configs -= [ "//build/config/clang:extra_warnings" ]
38 } 42 }
39
40 if (is_win) {
41 # https://code.google.com/p/snappy/issues/detail?id=75
42 cflags = [ "/wd4267" ] # Conversion from size_t to 'type'.
43 }
44 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698