Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/re2/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("re2_config") { 5 config("re2_config") {
6 include_dirs = [ "." ] 6 include_dirs = [ "." ]
7 } 7 }
8 8
9 static_library("re2") { 9 static_library("re2") {
10 sources = [ 10 sources = [
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 "util/sparse_array.h", 51 "util/sparse_array.h",
52 "util/sparse_set.h", 52 "util/sparse_set.h",
53 "util/stringpiece.cc", 53 "util/stringpiece.cc",
54 "util/stringprintf.cc", 54 "util/stringprintf.cc",
55 "util/strutil.cc", 55 "util/strutil.cc",
56 "util/utf.h", 56 "util/utf.h",
57 "util/util.h", 57 "util/util.h",
58 ] 58 ]
59 59
60 configs -= [ "//build/config/compiler:chromium_code" ] 60 configs -= [ "//build/config/compiler:chromium_code" ]
61 configs += [ "//build/config/compiler:no_chromium_code" ] 61 configs += [
62 "//build/config/compiler:no_chromium_code",
63 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
64 "//build/config/compiler:no_size_t_to_int_warning",
65 ]
62 public_configs = [ ":re2_config" ] 66 public_configs = [ ":re2_config" ]
63 67
64 deps = [ 68 deps = [
65 "//base/third_party/dynamic_annotations", 69 "//base/third_party/dynamic_annotations",
66 ] 70 ]
67 71
68 if (is_win) { 72 if (is_win) {
69 include_dirs = [ "mswin" ] 73 include_dirs = [ "mswin" ]
70 cflags = [ 74 cflags = [ "/wd4722" ] # Destructor never terminates.
71 "/wd4267", # Conversion from size_t.
72 "/wd4722", # Destructor never terminates.
73 ]
74 } else { 75 } else {
75 sources -= [ "mswin/stdint.h" ] 76 sources -= [ "mswin/stdint.h" ]
76 } 77 }
77 } 78 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698