Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: third_party/harfbuzz-ng/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/linux/pkg_config.gni") 5 import("//build/config/linux/pkg_config.gni")
6 6
7 # The GYP build supports system harfbuzz for non-official builds when using 7 # The GYP build supports system harfbuzz for non-official builds when using
8 # pangoft2 1.31.0 or greater (which pulls it in). 8 # pangoft2 1.31.0 or greater (which pulls it in).
9 # TODO(brettw) we can consider doing this as well, although the benefit is 9 # TODO(brettw) we can consider doing this as well, although the benefit is
10 # unclear and requires shelling out to a script to check the version. 10 # unclear and requires shelling out to a script to check the version.
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 ] 142 ]
143 143
144 defines = [ 144 defines = [
145 "HAVE_OT", 145 "HAVE_OT",
146 "HAVE_ICU", 146 "HAVE_ICU",
147 "HAVE_ICU_BUILTIN", 147 "HAVE_ICU_BUILTIN",
148 "HB_NO_MT", 148 "HB_NO_MT",
149 ] 149 ]
150 150
151 configs -= [ "//build/config/compiler:chromium_code" ] 151 configs -= [ "//build/config/compiler:chromium_code" ]
152 configs += [ "//build/config/compiler:no_chromium_code" ] 152 configs += [
153 "//build/config/compiler:no_chromium_code",
154 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
155 "//build/config/compiler:no_size_t_to_int_warning",
156 ]
153 public_configs = [ ":harfbuzz-ng_config" ] 157 public_configs = [ ":harfbuzz-ng_config" ]
154 158
155 deps = [ 159 deps = [
156 "//third_party/icu:icuuc", 160 "//third_party/icu:icuuc",
157 ] 161 ]
158 162
159 cflags = [] 163 cflags = []
160 if (is_clang) { 164 if (is_clang) {
161 cflags += [ "-Wno-unused-value" ] 165 cflags += [ "-Wno-unused-value" ]
162 } 166 }
163 if (is_win) { 167 if (is_win) {
164 cflags += [ 168 cflags += [
165 "/wd4267", # size_t to 'type' converion.
166 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits. 169 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits.
167 ] 170 ]
168 } 171 }
169 if (is_mac) { 172 if (is_mac) {
170 sources += [ 173 sources += [
171 "src/hb-coretext.cc", 174 "src/hb-coretext.cc",
172 "src/hb-coretext.h", 175 "src/hb-coretext.h",
173 ] 176 ]
174 defines += [ "HAVE_CORETEXT" ] 177 defines += [ "HAVE_CORETEXT" ]
175 } 178 }
176 } 179 }
177 } 180 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698