Issue 929773002: Revert of Don't always bail out of GenerateTypedArrayInitialize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 929773002: Revert of Don't always bail out of GenerateTypedArrayInitialize (Closed)

Created:
5 years, 10 months ago by Michael Achenbach

Modified:
5 years, 10 months ago

Reviewers:
Dmitry Lomov (no reviews), adamk

CC:
v8-dev, marja, rossberg

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Don't always bail out of GenerateTypedArrayInitialize (patchset #1 id:1 of https://codereview.chromium.org/922393003/) Reason for revert: Speculative revert. This CL seems to break octane. Original issue's description: > Don't always bail out of GenerateTypedArrayInitialize > > In an innocuous cleanup patch, https://code.google.com/p/v8/source/detail?r=21621, > some boolean logic got mixed up and the Hydrogen code for TypedArrayInitialize > was changed to always bail out. This swaps the logic appropriately. > > Committed: https://crrev.com/907f0b6ce573333f1cbca00db5cb1df1ead175bb > Cr-Commit-Position: refs/heads/master@{#26643} TBR=dslomov@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/38d0749c8d1991bd4e1a22289662d63cd00ae05f Cr-Commit-Position: refs/heads/master@{#26650}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Don't always bail out of GenerateTypedArrayInitialize

5 years, 10 months ago (2015-02-15 10:13:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929773002/1

5 years, 10 months ago (2015-02-15 10:14:34 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-15 10:14:57 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/38d0749c8d1991bd4e1a22289662d63cd00ae05f
Cr-Commit-Position: refs/heads/master@{#26650}