Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 929763002: X87: Implement ES6 rest parameters. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Implement ES6 rest parameters. port 8bb2e397745630375c3f189293cfbaf791a6403c (r26645). original commit message: BUG= Committed: https://crrev.com/34d5cc64868de613d4b02ca2337b764bee696366 Cr-Commit-Position: refs/heads/master@{#26649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 10 months ago (2015-02-15 06:53:02 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-15 07:04:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929763002/1
5 years, 10 months ago (2015-02-15 07:17:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-15 07:40:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-15 07:40:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34d5cc64868de613d4b02ca2337b764bee696366
Cr-Commit-Position: refs/heads/master@{#26649}

Powered by Google App Engine
This is Rietveld 408576698