Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 929753002: Turn off physical keyboard autocorrect feature by default. (Closed)

Created:
5 years, 10 months ago by Shu Chen
Modified:
5 years, 10 months ago
Reviewers:
177haala
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off physical keyboard autocorrect feature by default. And make the flag --enable-physical-keyboard-autocorrect as ENABLE_DISABLE_VALUE_TYPE. TBR=stevet@chromium.org BUG=422869 TEST=Verified on linux_chromeos. Committed: https://crrev.com/ae809092987564166189a1d966942e131d40c415 Cr-Commit-Position: refs/heads/master@{#316407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929753002/1
5 years, 10 months ago (2015-02-15 03:25:58 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25454)
5 years, 10 months ago (2015-02-15 04:35:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929753002/1
5 years, 10 months ago (2015-02-15 04:56:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-15 05:26:57 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae809092987564166189a1d966942e131d40c415 Cr-Commit-Position: refs/heads/master@{#316407}
5 years, 10 months ago (2015-02-15 05:27:50 UTC) #8
177haala
5 years, 10 months ago (2015-02-15 08:41:08 UTC) #10
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698